Prevent ThreadableLoaderClient methods from being called after failure notification

Source/core/loader/DocumentThreadableLoader.h

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2013, Intel Corporation
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 44 matching lines @@
 
 class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, private ResourceOwner<RawResource>  {
     WTF_MAKE_FAST_ALLOCATED(DocumentThreadableLoader);
     public:
         static void loadResourceSynchronously(Document&, const ResourceRequest&, ThreadableLoaderClient&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);
         static PassRefPtr<DocumentThreadableLoader> create(Document&, ThreadableLoaderClient*, const ResourceRequest&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);
         ~DocumentThreadableLoader() override;
 
         void overrideTimeout(unsigned long timeout) override;
 
+        // |this| may be dead after calling this method in async mode.
         void cancel() override;
         void setDefersLoading(bool);
 
     private:
         enum BlockingBehavior {
             LoadSynchronously,
             LoadAsynchronously
         };
 
         DocumentThreadableLoader(Document&, ThreadableLoaderClient*, BlockingBehavior, const ResourceRequest&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);
 
+        void clear();
+
         // ResourceClient
+        //
+        // |this| may be dead after calling this method.
         void notifyFinished(Resource*) override;
+
         // RawResourceClient
+        //
+        // |this| may be dead after calling these methods.
         void dataSent(Resource*, unsigned long long bytesSent, unsigned long long totalBytesToBeSent) override;
         void responseReceived(Resource*, const ResourceResponse&, PassOwnPtr<WebDataConsumerHandle>) override;
         void setSerializedCachedMetadata(Resource*, const char*, size_t) override;
         void dataReceived(Resource*, const char* data, unsigned dataLength) override;
         void redirectReceived(Resource*, ResourceRequest&, const ResourceResponse&) override;
         void dataDownloaded(Resource*, int) override;
         void didReceiveResourceTiming(Resource*, const ResourceTimingInfo&) override;
 
+        // |this| may be dead after calling this method in async mode.
         void cancelWithError(const ResourceError&);
 
         // Notify Inspector and log to console about resource response. Use
         // this method if response is not going to be finished normally.
         void reportResponseReceived(unsigned long identifier, const ResourceResponse&);
 
-        // Methods containing code to handle resource fetch results which is
+        // Methods containing code to handle resource fetch results which are
         // common to both sync and async mode.
+        //
+        // |this| may be dead after calling these method in async mode.
         void handleResponse(unsigned long identifier, const ResourceResponse&, PassOwnPtr<WebDataConsumerHandle>);
         void handleReceivedData(const char* data, unsigned dataLength);
+        void handleSuccessfulActualRequestFinish(unsigned long identifier, double finishTime);
         void handleSuccessfulFinish(unsigned long identifier, double finishTime);
 
+        // |this| may be dead after calling this method.
         void didTimeout(Timer<DocumentThreadableLoader>*);
         // Calls the appropriate loading method according to policy and data
         // about origin. Only for handling the initial load (including fallback
         // after consulting ServiceWorker).
+        //
+        // |this| may be dead after calling this method in async mode.
         void dispatchInitialRequest(const ResourceRequest&);
+        // |this| may be dead after calling this method in async mode.
         void makeCrossOriginAccessRequest(const ResourceRequest&);
         // Loads m_fallbackRequestForServiceWorker.
+        //
+        // |this| may be dead after calling this method in async mode.
         void loadFallbackRequestForServiceWorker();
         // Loads m_actualRequest.
         void loadActualRequest();
         // Clears m_actualRequest and reports access control check failure to
         // m_client.
+        //
+        // |this| may be dead after calling this method in async mode.
         void handlePreflightFailure(const String& url, const String& errorDescription);
         // Investigates the response for the preflight request. If successful,
         // the actual request will be made later in handleSuccessfulFinish().
+        //
+        // |this| may be dead after calling this method in async mode.
         void handlePreflightResponse(const ResourceResponse&);
+        // |this| may be dead after calling this method.
+        void handleError(const ResourceError&);
 
         void loadRequest(const ResourceRequest&, ResourceLoaderOptions);
         bool isAllowedRedirect(const KURL&) const;
         bool isAllowedByContentSecurityPolicy(const KURL&, ContentSecurityPolicy::RedirectStatus) const;
         // Returns DoNotAllowStoredCredentials
         // if m_forceDoNotAllowStoredCredentials is set. Otherwise, just
         // returns allowCredentials value of m_resourceLoaderOptions.
         StoredCredentials effectiveAllowCredentials() const;
 
         SecurityOrigin* securityOrigin() const;
@@ skipping 45 matching lines @@
         // But this value is not the max number of total redirects allowed,
         // because same-origin redirects are not counted here.
         int m_corsRedirectLimit;
 
         const WebURLRequest::FetchRedirectMode m_redirectMode;
     };
 
 } // namespace blink
 
 #endif // DocumentThreadableLoader_h