Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: src/objects-debug.cc

Issue 1262583002: Reland of "Remove ExternalArray, derived types, and element kinds" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index b68895fbc6d27745e4dd8e1ca6bc71674b772ef9..5babfdf1a7f434ce341a735b9daf1f9ee61813a5 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -78,9 +78,6 @@ void HeapObject::HeapObjectVerify() {
break;
#define VERIFY_TYPED_ARRAY(Type, type, TYPE, ctype, size) \
- case EXTERNAL_##TYPE##_ARRAY_TYPE: \
- External##Type##Array::cast(this)->External##Type##ArrayVerify(); \
- break; \
case FIXED_##TYPE##_ARRAY_TYPE: \
Fixed##Type##Array::cast(this)->FixedTypedArrayVerify(); \
break;
@@ -236,21 +233,17 @@ void FreeSpace::FreeSpaceVerify() {
}
-#define EXTERNAL_ARRAY_VERIFY(Type, type, TYPE, ctype, size) \
- void External##Type##Array::External##Type##ArrayVerify() { \
- CHECK(IsExternal##Type##Array()); \
- }
-
-TYPED_ARRAYS(EXTERNAL_ARRAY_VERIFY)
-#undef EXTERNAL_ARRAY_VERIFY
-
-
template <class Traits>
void FixedTypedArray<Traits>::FixedTypedArrayVerify() {
CHECK(IsHeapObject() &&
HeapObject::cast(this)->map()->instance_type() ==
Traits::kInstanceType);
- CHECK(base_pointer() == this);
+ if (base_pointer() == this) {
+ CHECK(external_pointer() ==
+ ExternalReference::fixed_typed_array_base_data_offset().address());
+ } else {
+ CHECK(base_pointer() == nullptr);
+ }
}
@@ -1096,7 +1089,6 @@ void JSObject::IncrementSpillStatistics(SpillInformation* info) {
}
#define TYPED_ARRAY_CASE(Type, type, TYPE, ctype, size) \
- case EXTERNAL_##TYPE##_ELEMENTS: \
case TYPE##_ELEMENTS:
TYPED_ARRAYS(TYPED_ARRAY_CASE)
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698