src/factory.h - Issue 1262583002: Reland of "Remove ExternalArray, derived types, and element kinds"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.h

Issue 1262583002: Reland of "Remove ExternalArray, derived types, and element kinds" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/factory.h

diff --git a/src/factory.h b/src/factory.h

index 1253779a1bb3071185ebd9cb124ff9fd276dcb21..9d42130ee1a85bc1facfd865240e0b5c70a512d1 100644

--- a/src/factory.h

+++ b/src/factory.h

@@ -286,10 +286,8 @@ class Factory final {

Handle<BytecodeArray> NewBytecodeArray(int length, const byte* raw_bytecodes,

int frame_size);

- Handle<ExternalArray> NewExternalArray(

- int length,

- ExternalArrayType array_type,

- void* external_pointer,

+ Handle<FixedTypedArrayBase> NewFixedTypedArrayWithExternalPointer(

+ int length, ExternalArrayType array_type, void* external_pointer,

PretenureFlag pretenure = NOT_TENURED);

Handle<FixedTypedArrayBase> NewFixedTypedArray(

« no previous file with comments | « src/elements-kind.cc ('k') | src/factory.cc » ('j') | no next file with comments »