Reland of "Remove ExternalArray, derived types, and element kinds"

src/hydrogen-uint32-analysis.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/hydrogen-uint32-analysis.h"
 
 namespace v8 {
 namespace internal {
 
 
 static bool IsUnsignedLoad(HLoadKeyed* instr) {
   switch (instr->elements_kind()) {
-    case EXTERNAL_UINT8_ELEMENTS:
-    case EXTERNAL_UINT16_ELEMENTS:
-    case EXTERNAL_UINT32_ELEMENTS:
-    case EXTERNAL_UINT8_CLAMPED_ELEMENTS:
     case UINT8_ELEMENTS:
     case UINT16_ELEMENTS:
     case UINT32_ELEMENTS:
     case UINT8_CLAMPED_ELEMENTS:
       return true;
     default:
       return false;
   }
 }
 
@@ skipping 16 matching lines @@
     // Conversions have special support for uint32.
     // This DCHECK guards that the conversion in question is actually
     // implemented. Do not extend the whitelist without adding
     // support to LChunkBuilder::DoChange().
     DCHECK(HChange::cast(use)->to().IsDouble() ||
            HChange::cast(use)->to().IsSmi() ||
            HChange::cast(use)->to().IsTagged());
     return true;
   } else if (use->IsStoreKeyed()) {
     HStoreKeyed* store = HStoreKeyed::cast(use);
-    if (store->is_external()) {
+    if (store->is_fixed_typed_array()) {
       // Storing a value into an external integer array is a bit level
       // operation.
       if (store->value() == val) {
         // Clamping or a conversion to double should have beed inserted.
-        DCHECK(store->elements_kind() != EXTERNAL_UINT8_CLAMPED_ELEMENTS);
-        DCHECK(store->elements_kind() != EXTERNAL_FLOAT32_ELEMENTS);
-        DCHECK(store->elements_kind() != EXTERNAL_FLOAT64_ELEMENTS);
+        DCHECK(store->elements_kind() != UINT8_CLAMPED_ELEMENTS);
+        DCHECK(store->elements_kind() != FLOAT32_ELEMENTS);
+        DCHECK(store->elements_kind() != FLOAT64_ELEMENTS);
         return true;
       }
     }
   } else if (use->IsCompareNumericAndBranch()) {
     HCompareNumericAndBranch* c = HCompareNumericAndBranch::cast(use);
     return IsUint32Operation(c->left()) && IsUint32Operation(c->right());
   }
 
   return false;
 }
@@ skipping 161 matching lines @@
   // Some phis might have been optimistically marked with kUint32 flag.
   // Remove this flag from those phis that are unsafe and propagate
   // this information transitively potentially clearing kUint32 flag
   // from some non-phi operations that are used as operands to unsafe phis.
   UnmarkUnsafePhis();
 }
 
 
 }  // namespace internal
 }  // namespace v8