Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1262503011: Re-enable ChannelMojo (Closed)

Created:
5 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 4 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@unfuck-everything
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable ChannelMojo The performance regression seen previously was probably misattributed to ChannelMojo. Also, given that a great deal of code will now take advantage of the channel's thread-safe Send, this is expected to result in an net performance improvement. BUG=500019 TBR=jam@chromium.org Committed: https://crrev.com/ab1a53c964a77dabb6d08b7199111b51a330885e Cr-Commit-Position: refs/heads/master@{#342055}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M ipc/mojo/ipc_channel_mojo.cc View 1 chunk +1 line, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262503011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262503011/20001
5 years, 4 months ago (2015-08-06 03:38:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 4 months ago (2015-08-06 03:43:59 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ab1a53c964a77dabb6d08b7199111b51a330885e Cr-Commit-Position: refs/heads/master@{#342055}
5 years, 4 months ago (2015-08-06 03:44:53 UTC) #5
hiroshige
5 years, 4 months ago (2015-08-06 09:27:39 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/1265383006/ by hiroshige@chromium.org.

The reason for reverting is: Suspecting this CL causes many Layout test failures
(https://crbug.com/517391)..

Powered by Google App Engine
This is Rietveld 408576698