mojo/common/BUILD.gn - Issue 1262503002: Revert of Gets gn check to execute cleanly in mojo/common

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/common/BUILD.gn

Issue 1262503002: Revert of Gets gn check to execute cleanly in mojo/common (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/common/BUILD.gn

diff --git a/mojo/common/BUILD.gn b/mojo/common/BUILD.gn

index 6499e724c2477e6c6bf3ae80cca3cfde74857414..15487985c934c6d4e9783d73ac9fbc61e7465eb6 100644

--- a/mojo/common/BUILD.gn

+++ b/mojo/common/BUILD.gn

@@ -12,7 +12,7 @@

}

# GYP version: mojo/mojo_base.gyp:mojo_common_lib

-source_set("common_base") {

+component("common_base") {

output_name = "mojo_common_lib"

sources = [

@@ -40,8 +40,6 @@

"//base",

"//base/third_party/dynamic_annotations",

"//third_party/mojo/src/mojo/public/c/system:for_component",

- "//third_party/mojo/src/mojo/public/cpp/bindings:bindings",

- "//third_party/mojo/src/mojo/public/cpp/system:system",

]

}

« no previous file with comments | « .gn ('k') | mojo/environment/BUILD.gn » ('j') | no next file with comments »