Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: content/browser/android/download_controller_android_impl.cc

Issue 12625005: remove call to get android MediaPlayer class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: moving getMetadata() call to java side Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/download_controller_android_impl.cc
diff --git a/content/browser/android/download_controller_android_impl.cc b/content/browser/android/download_controller_android_impl.cc
index d45bdf299dbe44b7d5689bd1727193e3e13b9c68..397f44576c585e06f56b2a162c5b1636595ad023 100644
--- a/content/browser/android/download_controller_android_impl.cc
+++ b/content/browser/android/download_controller_android_impl.cc
@@ -30,15 +30,9 @@
using base::android::AttachCurrentThread;
using base::android::CheckException;
using base::android::ConvertUTF8ToJavaString;
-using base::android::GetClass;
using base::android::MethodID;
using base::android::ScopedJavaLocalRef;
-namespace {
-const char kDownloadControllerClassPathName[] =
Yaron 2013/03/12 21:51:54 You can revert this. I've fixed this file in https
qinmin 2013/03/12 22:27:32 Done.
- "org/chromium/content/browser/DownloadController";
-} // namespace
-
namespace content {
// JNI methods
@@ -325,13 +319,11 @@ DownloadControllerAndroidImpl::JavaObject*
// DownloadController.getInstance(), which will call Init()
// if Java DownloadController is not instantiated already.
JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jclass> clazz =
- GetClass(env, kDownloadControllerClassPathName);
jmethodID get_instance = MethodID::Get<MethodID::TYPE_STATIC>(
- env, clazz.obj(), "getInstance",
+ env, g_DownloadController_clazz, "getInstance",
"()Lorg/chromium/content/browser/DownloadController;");
ScopedJavaLocalRef<jobject> jobj(env,
- env->CallStaticObjectMethod(clazz.obj(), get_instance));
+ env->CallStaticObjectMethod(g_DownloadController_clazz, get_instance));
CheckException(env);
}

Powered by Google App Engine
This is Rietveld 408576698