remove call to get android MediaPlayer class

media/base/android/media_player_bridge.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/android/media_player_bridge.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/basictypes.h"
 #include "base/logging.h"
@@ skipping 310 matching lines @@
 
   GetMetadata();
 
   media_prepared_cb_.Run(player_id_, duration_);
 }
 
 void MediaPlayerBridge::GetMetadata() {
   JNIEnv* env = AttachCurrentThread();
   CHECK(env);
 
-  ScopedJavaLocalRef<jclass> media_player_class(
-      GetClass(env, "android/media/MediaPlayer"));
   jmethodID method = MethodID::Get<MethodID::TYPE_INSTANCE>(
-      env, media_player_class.obj(), "getMetadata",
+      env, g_MediaPlayer_clazz, "getMetadata",

[Yaron, 2013/03/11 23:13:04]

That's not the change I was asking for, but it's a good change regardless. You
can leave the other updates in this patch, but I'd also like to see this
function call replacted with usage of the JNI generator.

Basically, after your patch this should only have things like:
Java_MediaPlayer_fooBar(env, ..)

and there shouldn't need to be any GetClass calls or CheckException calls. Since
you're doing a little bit of work with a system class, you'll probably want to
create a small java helper object and call a function on that. Let me know if
you want more specifics

[qinmin, 2013/03/12 16:36:24]

There is some problem with the metadata class. It is not exposed as a public SDK
API, but it is a public class in android. And the method is also public in
MediaPlayer.java.
So if I put this code logic into MediaPlayerBridge.java file, I will get a
compile error.
I will leave this as it is for now, but come up with another change to remove
this dependency.

On 2013/03/11 23:13:04, Yaron wrote:

[Yaron, 2013/03/12 16:50:25]

As discussed offline, this could be a sort of crashes in some versions of
Android. I'd rather explicitly expose this error (via reflection) than hide the
fact that we're essentially using reflection.

As you mentioned offline, if there's a better way of doing it, I'm glad to
pursue that, but having it being hidden is not a reason to keep this in C++

[qinmin, 2013/03/12 19:22:05]

Ok, moved the everything to java and return a boolean array to the native side.
And used reflection to check whether the methods are available in Java.

On 2013/03/12 16:50:25, Yaron wrote:

       "(ZZ)Landroid/media/Metadata;");
   ScopedJavaLocalRef<jobject> j_metadata(
       env, env->CallObjectMethod(
           j_media_player_.obj(), method, JNI_FALSE, JNI_FALSE));
   CheckException(env);
   if (j_metadata.is_null())
     return;
 
   ScopedJavaLocalRef<jclass> metadata_class(
       GetClass(env, "android/media/Metadata"));
@@ skipping 41 matching lines @@
 
 bool MediaPlayerBridge::RegisterMediaPlayerBridge(JNIEnv* env) {
   bool ret = RegisterNativesImpl(env);
   DCHECK(g_MediaPlayerBridge_clazz);
   if (ret)
     ret = JNI_MediaPlayer::RegisterNativesImpl(env);
   return ret;
 }
 
 }  // namespace media