remove call to get android MediaPlayer class

chrome/browser/history/android/sqlite_cursor.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/android/sqlite_cursor.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 42 matching lines @@
     JNIEnv* env,
     const std::vector<std::string>& column_names,
     history::AndroidStatement* statement,
     AndroidHistoryProviderService* service,
     FaviconService* favicon_service) {
   if (!HasClass(env, kSQLiteCursorClassPath)) {
     LOG(ERROR) << "Can not find " << kSQLiteCursorClassPath;
     return ScopedJavaLocalRef<jobject>();
   }
 
-  ScopedJavaLocalRef<jclass> sclass = GetClass(env, kSQLiteCursorClassPath);
   jmethodID method_id = MethodID::Get<MethodID::TYPE_INSTANCE>(
-      env, sclass.obj(), "<init>", "(I)V");
+      env, g_SQLiteCursor_clazz, "<init>", "(I)V");

[bulach, 2013/03/13 15:06:10]

while at it... :)
this is not a system class, but rather our own:
chrome/android/java/src/org/chromium/chrome/browser/database/SQLiteCursor.java

in which case, we should have a static factory method rather than inspect the
constructor..

and 58-75 could be simplified into:

SQLiteCursor* cursor = new SQLiteCursor(...);
ScopedJavaLocalRef<jobjec> ret(env,
    Java_SQLiteCursor_Create(reinterpret_cast<jint>(cursor));
return ret;

[qinmin, 2013/03/13 18:26:58]

Good point, Done.

 
   SQLiteCursor* cursor = new SQLiteCursor(column_names, statement, service,
                                           favicon_service);
   ScopedJavaLocalRef<jobject> obj(env,
-      env->NewObject(sclass.obj(), method_id, reinterpret_cast<jint>(cursor)));
+      env->NewObject(g_SQLiteCursor_clazz, method_id,
+                     reinterpret_cast<jint>(cursor)));
   if (obj.is_null()) {
     delete cursor;
     return ScopedJavaLocalRef<jobject>();
   }
   return obj;
 }
 
 bool SQLiteCursor::RegisterSqliteCursor(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 jint SQLiteCursor::GetCount(JNIEnv* env, jobject obj) {
   // Moves to maxium possible position so we will reach the last row, then finds
   // out the total number of rows.
   int current_position = position_;
   int count = MoveTo(env, obj, std::numeric_limits<int>::max() - 1) + 1;
   // Moves back to the previous position.
   MoveTo(env, obj, current_position);
   return count;
 }
 
 ScopedJavaLocalRef<jobjectArray> SQLiteCursor::GetColumnNames(JNIEnv* env,
                                                               jobject obj) {
   size_t count = column_names_.size();
   ScopedJavaLocalRef<jclass> sclass = GetClass(env, "java/lang/String");

[bulach, 2013/03/13 15:06:10]

94-103 could use base/android/jni_array.h and just:

return ToJavaArrayOfStrings(env, column_names_);

[qinmin, 2013/03/13 18:26:58]

Good catch, done.
On 2013/03/13 15:06:10, bulach wrote:

   ScopedJavaLocalRef<jobjectArray> arr(env,
       env->NewObjectArray(count, sclass.obj(), NULL));
   for (size_t i = 0; i < count; i++) {
     ScopedJavaLocalRef<jstring> str =
         ConvertUTF8ToJavaString(env, column_names_[i].c_str());
     env->SetObjectArrayElement(arr.obj(), i, str.obj());
   }
   return arr;
 }
 
@@ skipping 22 matching lines @@
                                                      jint column) {
   std::vector<unsigned char> blob;
 
   // Assume the client will only get favicon using GetBlob.
   if (statement_->favicon_index() == column) {
     if (!GetFavicon(statement_->statement()->ColumnInt(column), &blob))
       return ScopedJavaLocalRef<jbyteArray>();
   } else {
     statement_->statement()->ColumnBlobAsVector(column, &blob);
   }
   ScopedJavaLocalRef<jbyteArray> jb(env, env->NewByteArray(blob.size()));

[bulach, 2013/03/13 15:06:10]

ditto, 138-140:

return ToJavaByteArray(env, blob.data(), blob.size());

[qinmin, 2013/03/13 18:26:58]

vector::data() is introduced in C++11, use &blob[0] instead.
On 2013/03/13 15:06:10, bulach wrote:
Done.

   int count = 0;
   for (std::vector<unsigned char>::const_iterator i = blob.begin();
       i != blob.end(); ++i) {
     env->SetByteArrayRegion(jb.obj(), count++, 1, (jbyte *)i);
   }
   return jb;
 }
 
 jboolean SQLiteCursor::IsNull(JNIEnv* env, jobject obj, jint column) {
   return NULL_TYPE == GetColumnTypeInternal(column) ? JNI_TRUE : JNI_FALSE;
@@ skipping 128 matching lines @@
 }
 
 void SQLiteCursor::RunMoveStatementOnUIThread(int pos) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if (!consumer_.get())
     consumer_.reset(new CancelableRequestConsumer());
   service_->MoveStatement(
       statement_, position_, pos, consumer_.get(),
       base::Bind(&SQLiteCursor::OnMoved, base::Unretained(this)));
 }