remove call to get android MediaPlayer class

media/base/android/media_player_bridge.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/android/media_player_bridge.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/stringprintf.h"
 #include "base/message_loop_proxy.h"
 #include "jni/MediaPlayerBridge_jni.h"
 #include "jni/MediaPlayer_jni.h"
 #include "media/base/android/cookie_getter.h"
 #include "media/base/android/media_player_bridge_manager.h"
 
 using base::android::AttachCurrentThread;
 using base::android::CheckException;
 using base::android::ConvertUTF8ToJavaString;
 using base::android::GetClass;

[Yaron, 2013/03/12 21:51:54]

Update these. Please remove unnecessary ones and inline ones that wouldn't
introduce new line breaks

[qinmin, 2013/03/12 22:27:32]

Done.

 using base::android::JavaRef;
 using base::android::MethodID;
 using base::android::ScopedJavaLocalRef;
 
 // These constants are from the android source tree and need to be kept in
 // sync with android/media/MediaMetadata.java.
 static const jint kPauseAvailable = 1;
 static const jint kSeekBackwardAvailable = 2;
 static const jint kSeekForwardAvailable = 3;
 
@@ skipping 289 matching lines @@
 
   GetMetadata();
 
   media_prepared_cb_.Run(player_id_, duration_);
 }
 
 void MediaPlayerBridge::GetMetadata() {
   JNIEnv* env = AttachCurrentThread();
   CHECK(env);
 
-  ScopedJavaLocalRef<jclass> media_player_class(
-      GetClass(env, "android/media/MediaPlayer"));
-  jmethodID method = MethodID::Get<MethodID::TYPE_INSTANCE>(
-      env, media_player_class.obj(), "getMetadata",
-      "(ZZ)Landroid/media/Metadata;");
-  ScopedJavaLocalRef<jobject> j_metadata(
-      env, env->CallObjectMethod(
-          j_media_player_.obj(), method, JNI_FALSE, JNI_FALSE));
+  ScopedJavaLocalRef<jbooleanArray> boolean_array =
+      Java_MediaPlayerBridge_getMetadata(env, j_media_player_.obj());
+  jboolean* bools = env->GetBooleanArrayElements(boolean_array.obj(), NULL);
   CheckException(env);
-  if (j_metadata.is_null())
-    return;
 
-  ScopedJavaLocalRef<jclass> metadata_class(
-      GetClass(env, "android/media/Metadata"));
-  jmethodID get_boolean = MethodID::Get<MethodID::TYPE_INSTANCE>(
-      env, metadata_class.obj(), "getBoolean", "(I)Z");
-  can_pause_ = env->CallBooleanMethod(j_metadata.obj(),
-                                      get_boolean,
-                                      kPauseAvailable);
-  CheckException(env);
-  can_seek_forward_ = env->CallBooleanMethod(j_metadata.obj(),
-                                             get_boolean,
-                                             kSeekBackwardAvailable);
-  CheckException(env);
-  can_seek_backward_ = env->CallBooleanMethod(j_metadata.obj(),
-                                              get_boolean,
-                                              kSeekForwardAvailable);
-  CheckException(env);
+  can_pause_ = bools[0];
+  can_seek_forward_ = bools[1];
+  can_seek_backward_ = bools[2];
+  env->ReleaseBooleanArrayElements(boolean_array.obj(), bools, JNI_ABORT);
 }
 
 void MediaPlayerBridge::StartInternal() {
   JNIEnv* env = AttachCurrentThread();
   JNI_MediaPlayer::Java_MediaPlayer_start(env, j_media_player_.obj());
   if (!time_update_timer_.IsRunning()) {
     time_update_timer_.Start(
         FROM_HERE,
         base::TimeDelta::FromMilliseconds(kTimeUpdateInterval),
         this, &MediaPlayerBridge::DoTimeUpdate);
@@ skipping 17 matching lines @@
 
 bool MediaPlayerBridge::RegisterMediaPlayerBridge(JNIEnv* env) {
   bool ret = RegisterNativesImpl(env);
   DCHECK(g_MediaPlayerBridge_clazz);
   if (ret)
     ret = JNI_MediaPlayer::RegisterNativesImpl(env);
   return ret;
 }
 
 }  // namespace media