Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1262493002: Enable HTTP loading in Mojo dart content handler (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
abarth, abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Enable HTTP loading in Mojo dart content handler - Bring in Sky's DartLibraryProviderNetwork. - Extend DartControllerConfig to control whether or not network loading is used. - Use DartLibraryProviderNetwork if requested when loading scripts. - DartContentHandler supports loading raw .dart files and bundled .dartzip files. - Add heart beat test for http loading. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/352b6f7b7cf9aa4f18f5135a713410ce5f2a17ca

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -22 lines) Patch
M mojo/dart/embedder/dart_controller.h View 3 chunks +5 lines, -2 lines 0 comments Download
M mojo/dart/embedder/dart_controller.cc View 9 chunks +34 lines, -11 lines 0 comments Download
M mojo/dart/embedder/dart_state.h View 3 chunks +23 lines, -0 lines 0 comments Download
A mojo/dart/http_load_test/main.dart View 1 chunk +16 lines, -0 lines 0 comments Download
A mojo/dart/http_load_test/part0.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A + mojo/dart/http_load_test/runner.py View 3 chunks +4 lines, -5 lines 0 comments Download
A mojo/dart/http_load_test/tester.dart View 1 1 chunk +70 lines, -0 lines 0 comments Download
M mojo/tools/get_test_list.py View 1 chunk +6 lines, -0 lines 0 comments Download
M services/dart/content_handler_main.cc View 3 chunks +17 lines, -4 lines 0 comments Download
M services/dart/dart_app.h View 1 chunk +5 lines, -0 lines 0 comments Download
M services/dart/dart_app.cc View 2 chunks +54 lines, -0 lines 0 comments Download
M tonic/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A tonic/dart_library_provider_network.h View 1 chunk +39 lines, -0 lines 0 comments Download
A tonic/dart_library_provider_network.cc View 1 chunk +94 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Cutch
5 years, 4 months ago (2015-07-27 21:10:28 UTC) #2
abarth-chromium
LGTM, but I'm not sure I'm the best reviewer for this code.
5 years, 4 months ago (2015-07-27 21:17:39 UTC) #4
Cutch
5 years, 4 months ago (2015-07-27 22:09:11 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
352b6f7b7cf9aa4f18f5135a713410ce5f2a17ca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698