Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1262473004: Make GrGpu read/write pixels take GrSurface (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make GrGpu read/write pixels take GrSurface Committed: https://skia.googlesource.com/skia/+/6cb3cbe8e67db5fb94ba7d98f60833229b008544

Patch Set 1 #

Patch Set 2 : more #

Total comments: 6

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -58 lines) Patch
M src/gpu/GrBatchTarget.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 6 chunks +9 lines, -10 lines 0 comments Download
M src/gpu/GrGpu.h View 1 2 4 chunks +15 lines, -14 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 chunk +7 lines, -9 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 7 chunks +32 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bsalomon
This allows backends to decide whether it is possible to straight writes to render targets ...
5 years, 4 months ago (2015-07-29 20:45:05 UTC) #2
egdaniel
lgtm
5 years, 4 months ago (2015-07-29 21:12:10 UTC) #3
robertphillips
lgtm + nits https://codereview.chromium.org/1262473004/diff/20001/src/gpu/GrGpu.h File src/gpu/GrGpu.h (right): https://codereview.chromium.org/1262473004/diff/20001/src/gpu/GrGpu.h#newcode245 src/gpu/GrGpu.h:245: */ texture -> surface or remove ...
5 years, 4 months ago (2015-07-30 12:57:17 UTC) #4
bsalomon
https://codereview.chromium.org/1262473004/diff/20001/src/gpu/GrGpu.h File src/gpu/GrGpu.h (right): https://codereview.chromium.org/1262473004/diff/20001/src/gpu/GrGpu.h#newcode245 src/gpu/GrGpu.h:245: */ On 2015/07/30 12:57:17, robertphillips wrote: > texture -> ...
5 years, 4 months ago (2015-07-30 14:23:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262473004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262473004/40001
5 years, 4 months ago (2015-07-30 14:25:40 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 14:34:30 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6cb3cbe8e67db5fb94ba7d98f60833229b008544

Powered by Google App Engine
This is Rietveld 408576698