Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1262463002: Replace extensions icon with MD icon. (Closed)

Created:
5 years, 4 months ago by Evan Stade
Modified:
5 years, 4 months ago
Reviewers:
oshima, Dan Beam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace extensions icon with MD icon. This is only used on two dev-oriented pages (chrome://plugins and chrome://components) so I feel empowered to make this change. BUG=505953 TBR=oshima@chromium.org Committed: https://crrev.com/b0aa474c88a42e52130120156b09482dc0031469 Cr-Commit-Position: refs/heads/master@{#340585}

Patch Set 1 #

Total comments: 6

Patch Set 2 : get rid of div #

Patch Set 3 : re-add resources #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -46 lines) Patch
M chrome/browser/resources/components.css View 1 1 chunk +9 lines, -23 lines 0 comments Download
M chrome/browser/resources/plugins.css View 1 1 chunk +9 lines, -23 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Evan Stade
5 years, 4 months ago (2015-07-27 19:34:16 UTC) #2
oshima
c/a/theme lgtm
5 years, 4 months ago (2015-07-27 19:37:21 UTC) #4
Dan Beam
wow, such copy pasta between those 2 stylesheets :( https://codereview.chromium.org/1262463002/diff/1/chrome/browser/resources/components.css File chrome/browser/resources/components.css (right): https://codereview.chromium.org/1262463002/diff/1/chrome/browser/resources/components.css#newcode15 chrome/browser/resources/components.css:15: ...
5 years, 4 months ago (2015-07-27 20:30:30 UTC) #5
Dan Beam
https://codereview.chromium.org/1262463002/diff/1/chrome/browser/resources/components.css File chrome/browser/resources/components.css (left): https://codereview.chromium.org/1262463002/diff/1/chrome/browser/resources/components.css#oldcode45 chrome/browser/resources/components.css:45: padding-right: 95px; ^ also I assume you functionally changed ...
5 years, 4 months ago (2015-07-27 20:30:58 UTC) #6
Evan Stade
https://codereview.chromium.org/1262463002/diff/1/chrome/browser/resources/components.css File chrome/browser/resources/components.css (left): https://codereview.chromium.org/1262463002/diff/1/chrome/browser/resources/components.css#oldcode45 chrome/browser/resources/components.css:45: padding-right: 95px; On 2015/07/27 20:30:58, Dan Beam wrote: > ...
5 years, 4 months ago (2015-07-27 20:50:21 UTC) #7
Dan Beam
lgtm (linguine & gnocchi + tomato marinara)
5 years, 4 months ago (2015-07-27 20:52:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262463002/20001
5 years, 4 months ago (2015-07-27 20:59:05 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/76300) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 4 months ago (2015-07-27 21:21:07 UTC) #13
Evan Stade
the image is used in one more place, so I'm going to re-add the pngs ...
5 years, 4 months ago (2015-07-27 21:27:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262463002/40001
5 years, 4 months ago (2015-07-27 21:28:24 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-07-27 22:31:25 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 22:32:36 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b0aa474c88a42e52130120156b09482dc0031469
Cr-Commit-Position: refs/heads/master@{#340585}

Powered by Google App Engine
This is Rietveld 408576698