Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: pkg/analyzer/lib/src/generated/incremental_resolver.dart

Issue 1262453007: Update LineInfo during incremental resolution. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/incremental_resolver_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/incremental_resolver.dart
diff --git a/pkg/analyzer/lib/src/generated/incremental_resolver.dart b/pkg/analyzer/lib/src/generated/incremental_resolver.dart
index ff3ad1296542d0e9b1792382c3607d98cc84df1d..2fcef7bc73b31fd177eb6f2b7bee0fc448e3761f 100644
--- a/pkg/analyzer/lib/src/generated/incremental_resolver.dart
+++ b/pkg/analyzer/lib/src/generated/incremental_resolver.dart
@@ -23,7 +23,7 @@ import 'package:analyzer/src/task/dart.dart'
VERIFY_ERRORS;
import 'package:analyzer/task/dart.dart'
show DART_ERRORS, LibrarySpecificUnit, PARSED_UNIT, TOKEN_STREAM;
-import 'package:analyzer/task/general.dart' show CONTENT;
+import 'package:analyzer/task/general.dart' show CONTENT, LINE_INFO;
import 'package:analyzer/task/model.dart' show ResultDescriptor;
import 'ast.dart';
@@ -1275,6 +1275,7 @@ class PoorMansIncrementalResolver {
int _updateEndOld;
int _updateEndNew;
+ LineInfo _newLineInfo;
List<AnalysisError> _newScanErrors = <AnalysisError>[];
List<AnalysisError> _newParseErrors = <AnalysisError>[];
@@ -1509,6 +1510,7 @@ class PoorMansIncrementalResolver {
CharSequenceReader reader = new CharSequenceReader(code);
Scanner scanner = new Scanner(_unitSource, reader, errorListener);
Token token = scanner.tokenize();
+ _newLineInfo = new LineInfo(scanner.lineStarts);
_newScanErrors = errorListener.errors;
return token;
}
@@ -1565,6 +1567,7 @@ class PoorMansIncrementalResolver {
_newSourceEntry.setState(SCAN_ERRORS, CacheState.INVALID);
List<TargetedResult> scanDeps =
<TargetedResult>[new TargetedResult(_unitSource, CONTENT)];
+ _newSourceEntry.setValue(LINE_INFO, _newLineInfo, scanDeps);
_newSourceEntry.setValue(SCAN_ERRORS, _newScanErrors, scanDeps);
// parse results
List<TargetedResult> parseDeps =
@@ -1575,6 +1578,7 @@ class PoorMansIncrementalResolver {
}
void _updateEntry_OLD() {
+ _oldEntry.setValue(SourceEntry.LINE_INFO, _newLineInfo);
_oldEntry.setValue(DartEntry.SCAN_ERRORS, _newScanErrors);
_oldEntry.setValue(DartEntry.PARSE_ERRORS, _newParseErrors);
}
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/incremental_resolver_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698