Issue 1262453006: Fix return check in CFX_FolderFontInfo::ScanFile() fread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1262453006: Fix return check in CFX_FolderFontInfo::ScanFile() fread. (Closed)

Created:
5 years, 4 months ago by Tom Sepez

Modified:
5 years, 4 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix return check in CFX_FolderFontInfo::ScanFile() fread. If you want to check the number of bytes read, you need to change the order of arguments. TEST=testing/corpus/fx/mulobj/1/1_10_watermark.pdf.0.png R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6fc1bf199833d6cb409e8134fe5d6894e8323673

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	core/src/fxge/ge/fx_ge_fontmap.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

Lei, we broke this a while ago, but I dont think it impacts chromium's use ...

5 years, 4 months ago (2015-07-30 22:26:17 UTC) #2

Tom Sepez

5 years, 4 months ago (2015-07-30 22:54:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6fc1bf199833d6cb409e8134fe5d6894e8323673 (presubmit successful).