Issue 126243002: Add the override annotation to all necessary methods in .../quic/.

Issue 126243002: Add the override annotation to all necessary methods in .../quic/. (Closed)

Created:
6 years, 11 months ago by ramant (doing other things)

Modified:
6 years, 11 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add the override annotation to all necessary methods in .../quic/. Merge internal change: 59008686 R=rch@chromium.org

Patch Set 2 : Removed OVERRIDE on virtual destructor #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -14 lines)			Patch
M	net/quic/crypto/local_strike_register_client_test.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	net/quic/crypto/quic_crypto_server_config_test.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	net/quic/quic_connection_helper.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/quic/quic_default_packet_writer.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/quic/quic_stream_sequencer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/test_tools/delayed_verify_strike_register_client.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	net/quic/test_tools/mock_clock.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/quic/test_tools/mock_crypto_client_stream_factory.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/quic/quic_client.h	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	net/tools/quic/quic_server.h	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	net/tools/quic/test_tools/quic_test_utils.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm https://codereview.chromium.org/126243002/diff/1/net/quic/quic_stream_sequencer.h File net/quic/quic_stream_sequencer.h (right): https://codereview.chromium.org/126243002/diff/1/net/quic/quic_stream_sequencer.h#newcode36 net/quic/quic_stream_sequencer.h:36: virtual ~QuicStreamSequencer() ; Did you mean to add ...

6 years, 11 months ago (2014-01-07 20:15:08 UTC) #2

ramant (doing other things)

https://codereview.chromium.org/126243002/diff/1/net/quic/quic_stream_sequencer.h File net/quic/quic_stream_sequencer.h (right): https://codereview.chromium.org/126243002/diff/1/net/quic/quic_stream_sequencer.h#newcode36 net/quic/quic_stream_sequencer.h:36: virtual ~QuicStreamSequencer() ; On 2014/01/07 20:15:09, Ryan Hamilton wrote: ...

6 years, 11 months ago (2014-01-07 20:26:05 UTC) #3

ramant (doing other things)

6 years, 11 months ago (2014-01-07 21:40:21 UTC) #4

Removed OVERRIDE on virtual destructor to fix win and win_rel compilation
errors.

Expand Messages | Collapse Messages