Ensure the memory reduces makes progress.

Ensure the memory reduces makes progress.

BUG=

Committed: https://crrev.com/b4cfd60e07f53a7df3201c473929b17df29a202f
Cr-Commit-Position: refs/heads/master@{#29950}

[ulan, 2015-07-30 13:20:18]

ulan@chromium.org changed reviewers:
+ hpayer@chromium.org

[ulan, 2015-07-30 13:20:19]

ptal

https://codereview.chromium.org/1262363002/diff/1/src/heap/memory-reducer.cc
File src/heap/memory-reducer.cc (right):

https://codereview.chromium.org/1262363002/diff/1/src/heap/memory-reducer.cc#...
src/heap/memory-reducer.cc:135: (state.last_gc_time_ms != 0 &&
This is the main change.

Other lines in this function ensure that state.last_gc_time_ms = event.time_ms
for mark-compact event or doesn't change.

[Hannes Payer (out of office), 2015-07-30 14:28:03]

LGTM

https://codereview.chromium.org/1262363002/diff/1/src/heap/memory-reducer.cc
File src/heap/memory-reducer.cc (right):

https://codereview.chromium.org/1262363002/diff/1/src/heap/memory-reducer.cc#...
src/heap/memory-reducer.cc:135: (state.last_gc_time_ms != 0 &&
On 2015/07/30 13:20:19, ulan wrote:
> This is the main change.
> 
> Other lines in this function ensure that state.last_gc_time_ms = event.time_ms
> for mark-compact event or doesn't change.

Can we make the watchdog part a boolean function to increase readability?

https://codereview.chromium.org/1262363002/diff/20001/src/heap/memory-reducer.h
File src/heap/memory-reducer.h (right):

https://codereview.chromium.org/1262363002/diff/20001/src/heap/memory-reducer...
src/heap/memory-reducer.h:33: // The <last_gc_start_ms> is a double that stores
the time of the last GC.
full GC

[ulan, 2015-07-31 09:47:44]

Thanks, landing.

https://codereview.chromium.org/1262363002/diff/1/src/heap/memory-reducer.cc
File src/heap/memory-reducer.cc (right):

https://codereview.chromium.org/1262363002/diff/1/src/heap/memory-reducer.cc#...
src/heap/memory-reducer.cc:135: (state.last_gc_time_ms != 0 &&
On 2015/07/30 14:28:03, Hannes Payer wrote:
> On 2015/07/30 13:20:19, ulan wrote:
> > This is the main change.
> > 
> > Other lines in this function ensure that state.last_gc_time_ms =
event.time_ms
> > for mark-compact event or doesn't change.
> 
> Can we make the watchdog part a boolean function to increase readability?

Done.

https://codereview.chromium.org/1262363002/diff/20001/src/heap/memory-reducer.h
File src/heap/memory-reducer.h (right):

https://codereview.chromium.org/1262363002/diff/20001/src/heap/memory-reducer...
src/heap/memory-reducer.h:33: // The <last_gc_start_ms> is a double that stores
the time of the last GC.
On 2015/07/30 14:28:03, Hannes Payer wrote:
> full GC

Done.

[ulan, 2015-07-31 09:47:52]

The CQ bit was checked by ulan@chromium.org

[ulan, 2015-07-31 09:47:52]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1262363002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-07-31 09:48:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1262363002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1262363002/60001

[commit-bot: I haz the power, 2015-07-31 10:28:04]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-31 10:28:28]

Patchset 4 (id:??) landed as
https://crrev.com/b4cfd60e07f53a7df3201c473929b17df29a202f
Cr-Commit-Position: refs/heads/master@{#29950}