Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: Source/bindings/templates/interface.cpp

Issue 1262353002: Add access checks to V8WrapperInstationScope. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/interface.cpp
diff --git a/Source/bindings/templates/interface.cpp b/Source/bindings/templates/interface.cpp
index 4373f5abbfdbd424984ac3e043de25170f7dea41..029dda009d3de52ebb0db6c5b31e2ff07b03bc36 100644
--- a/Source/bindings/templates/interface.cpp
+++ b/Source/bindings/templates/interface.cpp
@@ -560,8 +560,8 @@ void {{v8_class}}::visitDOMWrapper(v8::Isolate* isolate, ScriptWrappable* script
{
{{cpp_class}}* impl = scriptWrappable->toImpl<{{cpp_class}}>();
{% if set_wrapper_reference_to %}
- v8::Local<v8::Object> creationContext = v8::Local<v8::Object>::New(isolate, wrapper);
- V8WrapperInstantiationScope scope(creationContext, isolate);
+ v8::Local<v8::Object> context = v8::Local<v8::Object>::New(isolate, wrapper);
+ v8::Context::Scope scope(context->CreationContext());
{{set_wrapper_reference_to.cpp_type}} {{set_wrapper_reference_to.name}} = impl->{{set_wrapper_reference_to.name}}();
if ({{set_wrapper_reference_to.name}}) {
if (DOMDataStore::containsWrapper({{set_wrapper_reference_to.name}}, isolate))

Powered by Google App Engine
This is Rietveld 408576698