Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2343)

Unified Diff: base/trace_event/memory_dump_manager.cc

Issue 1262333005: [tracing] Introduce MemoryDumpArgs to enable light and heavy dumps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Made changes. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/memory_dump_manager.cc
diff --git a/base/trace_event/memory_dump_manager.cc b/base/trace_event/memory_dump_manager.cc
index d076dda05054ce70e2f5e009c7103d68ea03c6db..e4ed9955264109a46a29154b05a7d93515f8d005 100644
--- a/base/trace_event/memory_dump_manager.cc
+++ b/base/trace_event/memory_dump_manager.cc
@@ -311,8 +311,14 @@ void MemoryDumpManager::ContinueAsyncProcessDump(
// Invoke the dump provider without holding the |lock_|.
bool finalize = false;
bool dump_successful = false;
+
+ // TODO(ssid): Change RequestGlobalDump to use MemoryDumpArgs along with
+ // MemoryDumpType to get request for light / heavy dump, and remove this
+ // constant.
if (!skip_dump)
petrcermak 2015/08/03 10:12:35 nit: I think this would be more readable with brac
ssid 2015/08/03 10:34:02 Done.
- dump_successful = mdp->OnMemoryDump(&pmd_async_state->process_memory_dump);
+ dump_successful =
+ mdp->OnMemoryDump(MemoryDumpArgs(MemoryDumpArgs::LEVEL_OF_DETAIL_HIGH),
+ &pmd_async_state->process_memory_dump);
{
AutoLock lock(lock_);

Powered by Google App Engine
This is Rietveld 408576698