Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/gpu/browser_gpu_memory_buffer_manager.cc

Issue 1262333005: [tracing] Introduce MemoryDumpArgs to enable light and heavy dumps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Win and android fix. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/trace_event/trace_log.cc ('K') | « content/browser/gpu/browser_gpu_memory_buffer_manager.h ('k') | content/child/child_discardable_shared_memory_manager.h » ('j') | gin/v8_isolate_memory_dump_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/gpu/browser_gpu_memory_buffer_manager.cc
diff --git a/content/browser/gpu/browser_gpu_memory_buffer_manager.cc b/content/browser/gpu/browser_gpu_memory_buffer_manager.cc
index 21c81ca1424050eb251aa33f19480bbe3438d052..545730052b48100612c35a89c0208c8a4588de17 100644
--- a/content/browser/gpu/browser_gpu_memory_buffer_manager.cc
+++ b/content/browser/gpu/browser_gpu_memory_buffer_manager.cc
@@ -261,7 +261,11 @@ void BrowserGpuMemoryBufferManager::SetDestructionSyncPoint(
}
bool BrowserGpuMemoryBufferManager::OnMemoryDump(
+ const base::trace_event::MemoryDumpArgs& args,
base::trace_event::ProcessMemoryDump* pmd) {
+ // TODO(ssid): Use MemoryDumpArgs to create light dumps when requested
+ // (crbug.com/499731).
+
DCHECK_CURRENTLY_ON(BrowserThread::IO);
for (const auto& client : clients_) {
« base/trace_event/trace_log.cc ('K') | « content/browser/gpu/browser_gpu_memory_buffer_manager.h ('k') | content/child/child_discardable_shared_memory_manager.h » ('j') | gin/v8_isolate_memory_dump_provider.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698