base/trace_event/process_memory_totals_dump_provider.cc - Issue 1262333005: [tracing] Introduce MemoryDumpArgs to enable light and heavy dumps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/process_memory_totals_dump_provider.cc

Issue 1262333005: [tracing] Introduce MemoryDumpArgs to enable light and heavy dumps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/trace_event/process_memory_totals_dump_provider.h ('k') | base/trace_event/process_memory_totals_dump_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/trace_event/process_memory_totals_dump_provider.cc

diff --git a/base/trace_event/process_memory_totals_dump_provider.cc b/base/trace_event/process_memory_totals_dump_provider.cc

index 37f9bed68c9b2b4e59e8b83b70fc776c5117906a..a8617207dcfc35350496ebf7b27c8d758c891679 100644

--- a/base/trace_event/process_memory_totals_dump_provider.cc

+++ b/base/trace_event/process_memory_totals_dump_provider.cc

@@ -53,7 +53,8 @@ ProcessMemoryTotalsDumpProvider::~ProcessMemoryTotalsDumpProvider() {

// Called at trace dump point time. Creates a snapshot the memory counters for

// the current process.

-bool ProcessMemoryTotalsDumpProvider::OnMemoryDump(ProcessMemoryDump* pmd) {

+bool ProcessMemoryTotalsDumpProvider::OnMemoryDump(const MemoryDumpArgs& args,

+ ProcessMemoryDump* pmd) {

const uint64 rss_bytes = rss_bytes_for_testing

? rss_bytes_for_testing

: process_metrics_->GetWorkingSetSize();