Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc

Issue 12623029: Upstreaming mechanism to add query refinement to omnibox searches. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed ChromeOS. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc
diff --git a/chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc b/chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc
index 7c43efba84d183db70c772981879d14203a7da13..87fb3f3208c689ebf46c722be078e3873cab52d6 100644
--- a/chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc
+++ b/chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc
@@ -155,6 +155,7 @@ void OmniboxUIHandler::StartOmniboxQuery(const base::ListValue* input) {
return_val = input->GetBoolean(3, &prefer_keyword);
DCHECK(return_val);
string16 empty_string;
+ GURL empty_url;
Peter Kasting 2013/03/22 20:20:06 Nit: Let's nuke |empty_string| and |empty_url| and
beaudoin 2013/03/22 23:10:43 Done.
// Reset the controller. If we don't do this, then the
// AutocompleteController might inappropriately set its |minimal_changes|
// variable (or something else) and some providers will short-circuit
@@ -166,6 +167,7 @@ void OmniboxUIHandler::StartOmniboxQuery(const base::ListValue* input) {
input_string,
cursor_position,
empty_string, // user's desired tld (top-level domain)
+ empty_url,
prevent_inline_autocomplete,
prefer_keyword,
true, // allow exact keyword matches

Powered by Google App Engine
This is Rietveld 408576698