Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1942)

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_apitest.cc

Issue 12623029: Upstreaming mechanism to add query refinement to omnibox searches. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Applied Peter's comments. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/omnibox/omnibox_apitest.cc
diff --git a/chrome/browser/extensions/api/omnibox/omnibox_apitest.cc b/chrome/browser/extensions/api/omnibox/omnibox_apitest.cc
index 97a4ae86079bfdd94c145e4d8e72228fac344f8d..49dce1b498ed5eb30d30f35b7d04191d78be3a0d 100644
--- a/chrome/browser/extensions/api/omnibox/omnibox_apitest.cc
+++ b/chrome/browser/extensions/api/omnibox/omnibox_apitest.cc
@@ -79,7 +79,8 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, Basic) {
{
autocomplete_controller->Start(
AutocompleteInput(ASCIIToUTF16("keywor"), string16::npos, string16(),
- true, false, true, AutocompleteInput::ALL_MATCHES));
+ GURL(), true, false, true,
+ AutocompleteInput::ALL_MATCHES));
WaitForAutocompleteDone(autocomplete_controller);
EXPECT_TRUE(autocomplete_controller->done());
@@ -100,7 +101,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, Basic) {
{
autocomplete_controller->Start(
AutocompleteInput(ASCIIToUTF16("keyword suggestio"), string16::npos,
- string16(), true, false, true,
+ string16(), GURL(), true, false, true,
AutocompleteInput::ALL_MATCHES));
WaitForAutocompleteDone(autocomplete_controller);
EXPECT_TRUE(autocomplete_controller->done());
@@ -228,7 +229,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, PopupStaysClosed) {
// location_bar or location_bar->().
autocomplete_controller->Start(
AutocompleteInput(ASCIIToUTF16("keyword command"), string16::npos,
- string16(), true, false, true,
+ string16(), GURL(), true, false, true,
AutocompleteInput::ALL_MATCHES));
location_bar->AcceptInput();
WaitForAutocompleteDone(autocomplete_controller);
@@ -268,7 +269,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, DISABLED_IncognitoSplitMode) {
{
autocomplete_controller->Start(
AutocompleteInput(ASCIIToUTF16("keyword suggestio"), string16::npos,
- string16(), true, false, true,
+ string16(), GURL(), true, false, true,
AutocompleteInput::ALL_MATCHES));
WaitForAutocompleteDone(autocomplete_controller);
EXPECT_TRUE(autocomplete_controller->done());
@@ -290,7 +291,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, DISABLED_IncognitoSplitMode) {
ResultCatcher catcher;
autocomplete_controller->Start(
AutocompleteInput(ASCIIToUTF16("keyword command incognito"),
- string16::npos, string16(), true, false, true,
+ string16::npos, string16(), GURL(), true, false, true,
AutocompleteInput::ALL_MATCHES));
location_bar->AcceptInput();
EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
« no previous file with comments | « chrome/browser/autocomplete/shortcuts_provider_unittest.cc ('k') | chrome/browser/search_engines/template_url.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698