chrome/browser/autocomplete/autocomplete_result_unittest.cc - Issue 12623029: Upstreaming mechanism to add query refinement to omnibox searches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/autocomplete_result_unittest.cc

Issue 12623029: Upstreaming mechanism to add query refinement to omnibox searches. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Applied Peter's comments. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/autocomplete_provider_unittest.cc ('k') | chrome/browser/autocomplete/bookmark_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/autocomplete_result_unittest.cc

diff --git a/chrome/browser/autocomplete/autocomplete_result_unittest.cc b/chrome/browser/autocomplete/autocomplete_result_unittest.cc

index 64b0b702fa9c691f4b0f1a3a2937c97a63e03005..55af6ea3e0c3865f4d36a57300275b5980bd1659 100644

--- a/chrome/browser/autocomplete/autocomplete_result_unittest.cc

+++ b/chrome/browser/autocomplete/autocomplete_result_unittest.cc

@@ -115,8 +115,8 @@ void AutocompleteResultTest::RunCopyOldMatchesTest(

const TestData* last, size_t last_size,

const TestData* current, size_t current_size,

const TestData* expected, size_t expected_size) {

- AutocompleteInput input(ASCIIToUTF16("a"), string16::npos, string16(), false,

- false, false, AutocompleteInput::ALL_MATCHES);

+ AutocompleteInput input(ASCIIToUTF16("a"), string16::npos, string16(), GURL(),

+ false, false, false, AutocompleteInput::ALL_MATCHES);

ACMatches last_matches;

PopulateAutocompleteMatches(last, last_size, &last_matches);

@@ -147,8 +147,8 @@ TEST_F(AutocompleteResultTest, Swap) {

// Swap with a single match.

ACMatches matches;

AutocompleteMatch match;

- AutocompleteInput input(ASCIIToUTF16("a"), string16::npos, string16(), false,

- false, false, AutocompleteInput::ALL_MATCHES);

+ AutocompleteInput input(ASCIIToUTF16("a"), string16::npos, string16(), GURL(),

+ false, false, false, AutocompleteInput::ALL_MATCHES);

matches.push_back(match);

r1.AppendMatches(matches);

r1.SortAndCull(input, test_util_.profile());

@@ -228,8 +228,8 @@ TEST_F(AutocompleteResultTest, SortAndCullEmptyDestinationURLs) {

AutocompleteResult result;

result.AppendMatches(matches);

- AutocompleteInput input(string16(), string16::npos, string16(), false, false,

- false, AutocompleteInput::ALL_MATCHES);

+ AutocompleteInput input(string16(), string16::npos, string16(), GURL(), false,

+ false, false, AutocompleteInput::ALL_MATCHES);

result.SortAndCull(input, test_util_.profile());

// Of the two results with the same non-empty destination URL, the

@@ -272,8 +272,8 @@ TEST_F(AutocompleteResultTest, SortAndCullDuplicateSearchURLs) {