Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(120)

Issue 12623014: Merge 145293 "[HTMLTemplateElement] processTemplateEndTag() need..." (Closed)

Created:
7 years, 6 months ago by rafaelw
Modified:
7 years, 6 months ago
Reviewers:
rafaelw
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 145293 "[HTMLTemplateElement] processTemplateEndTag() need..." > [HTMLTemplateElement] processTemplateEndTag() needs to check for template in html scope > https://bugs.webkit.org/show_bug.cgi?id=111880 > > Reviewed by Eric Seidel. > > Source/WebCore: > > Currently, </template> handling exits with an error if there is not a template tag "in scope" > which will be true if there is a table (for instance) below a template. This makes it so that > the search (correctly) examines the entire element stack. > > Tests added to html5lib testing library. > > * html/parser/HTMLTreeBuilder.cpp: > (WebCore::HTMLTreeBuilder::processTemplateEndTag): > > LayoutTests: > > * html5lib/resources/template.dat: TBR=rafaelw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M LayoutTests/html5lib/resources/template.dat View 1 chunk +39 lines, -0 lines 0 comments Download
M Source/WebCore/html/parser/HTMLTreeBuilder.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
rafaelw
7 years, 6 months ago (2013-03-12 18:15:01 UTC) #1
rafaelw
7 years, 6 months ago (2013-03-12 18:16:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r145566.

Powered by Google App Engine
This is Rietveld 408576698