Issue 12623014: Merge 145293 "[HTMLTemplateElement] processTemplateEndTag() need..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12623014: Merge 145293 "[HTMLTemplateElement] processTemplateEndTag() need..." (Closed)

Created:
7 years, 9 months ago by rafaelw

Modified:
7 years, 9 months ago

Reviewers:
rafaelw

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/

Visibility:
Public.

More Reviews

Description

Merge 145293 "[HTMLTemplateElement] processTemplateEndTag() need..." > [HTMLTemplateElement] processTemplateEndTag() needs to check for template in html scope > https://bugs.webkit.org/show_bug.cgi?id=111880 > > Reviewed by Eric Seidel. > > Source/WebCore: > > Currently, </template> handling exits with an error if there is not a template tag "in scope" > which will be true if there is a table (for instance) below a template. This makes it so that > the search (correctly) examines the entire element stack. > > Tests added to html5lib testing library. > > * html/parser/HTMLTreeBuilder.cpp: > (WebCore::HTMLTreeBuilder::processTemplateEndTag): > > LayoutTests: > > * html5lib/resources/template.dat: TBR=rafaelw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145566

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -1 line)			Patch
	M	LayoutTests/html5lib/resources/template.dat	View		1 chunk	+39 lines, -0 lines	0 comments	Download
	M	Source/WebCore/html/parser/HTMLTreeBuilder.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r145566.

Expand Messages | Collapse Messages