Issue 12623011: add (temp) SkFontLCDConfig class to hold LCD getters/setters. This will allow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12623011: add (temp) SkFontLCDConfig class to hold LCD getters/setters. This will allow (Closed)

Created:
7 years, 9 months ago by reed1

Modified:
7 years, 9 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/

Visibility:
Public.

More Reviews

Description

add (temp) SkFontLCDConfig class to hold LCD getters/setters. This will allow us to make SkFontHost.h private (once webkit switches to the SkFontLCDConfig api) Stage 2 is to either move this code into chrome/webkit, or change the callers to perform their own globals management. Committed: https://code.google.com/p/skia/source/detail?r=8107

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+105 lines, -29 lines)			Patch
M	trunk/include/core/SkDeviceProperties.h	View	2 chunks	+11 lines, -11 lines	0 comments	Download
M	trunk/include/core/SkFontHost.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A	trunk/include/core/SkFontLCDConfig.h	View	1 chunk	+59 lines, -0 lines	0 comments	Download
M	trunk/src/core/SkFontHost.cpp	View	2 chunks	+30 lines, -17 lines	0 comments	Download
M	trunk/src/ports/SkFontHost_fontconfig.cpp	View	3 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

reed1

7 years, 9 months ago (2013-03-12 15:41:22 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r8107 (presubmit successful).

Expand Messages | Collapse Messages