[mac] App shims

chrome/common/app_shim_messages.h

Index: chrome/common/app_shim_messages.h
diff --git a/chrome/common/app_shim_messages.h b/chrome/common/app_shim_messages.h
new file mode 100644
index 0000000000000000000000000000000000000000..e63d0ba8570b60a2143f24f03ab396af54aada59
--- /dev/null
+++ b/chrome/common/app_shim_messages.h
@@ -0,0 +1,18 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Multiply-included message file, hence no include guard.
+
+#include <string>
+
+#include "ipc/ipc_message_macros.h"
+
+#define IPC_MESSAGE_START AppShimMsgStart

[jeremy, 2013/03/11 06:49:59]

Since we're dealing with new IPC messages can you double check that you're
validating all parameters defensively when receiving these messages?  Also,
might want to get someone from the security team to double-check this part of
the code review.

[jeremya, 2013/03/11 08:42:26]

Good idea. I think palmer@ is a security fellow?

I'm not entirely sure how to validate the profile name...

+
+IPC_MESSAGE_CONTROL1(AppShimMsg_LaunchApp_Done,

[jeremy, 2013/03/11 06:49:59]

Comments on what each message does.

[jeremya, 2013/03/11 08:42:26]

Done.

+                     bool /* succeeded */)
+
+IPC_MESSAGE_CONTROL2(AppShimHostMsg_LaunchApp,
+                     std::string /* profile name */,
+                     std::string /* app id */)