[mac] App shims

chrome/browser/web_applications/app_shim_host_controller.h

Index: chrome/browser/web_applications/app_shim_host_controller.h
diff --git a/chrome/browser/web_applications/app_shim_host_controller.h b/chrome/browser/web_applications/app_shim_host_controller.h
new file mode 100644
index 0000000000000000000000000000000000000000..432c88559282d31f13f3f3a70e657d58560da502
--- /dev/null
+++ b/chrome/browser/web_applications/app_shim_host_controller.h
@@ -0,0 +1,32 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_WEB_APPLICATIONS_APP_SHIM_HOST_CONTROLLER_H_
+#define CHROME_BROWSER_WEB_APPLICATIONS_APP_SHIM_HOST_CONTROLLER_H_
+
+#include "base/mac/scoped_cftyperef.h"
+#include "base/memory/weak_ptr.h"
+#include "base/threading/thread.h"
+#include "ipc/ipc_channel_factory.h"
+
+// The AppShimHostController receives connections from app shims on a UNIX
+// socket (|factory_|) and creates a helper object to manage the connection.

[jeremy, 2013/03/11 06:49:59]

What kind of object is the helper object?
Also comments for methods below.

[jeremya, 2013/03/11 08:42:26]

It's an AppShimHost, but that class is local to the .cc file... should I mention
it by name here anyway?

+class AppShimHostController
+    : public IPC::ChannelFactory::Delegate,
+      public base::SupportsWeakPtr<AppShimHostController> {
+ public:
+  AppShimHostController();
+  virtual ~AppShimHostController();
+
+ private:
+  virtual void OnClientConnected(const IPC::ChannelHandle& handle) OVERRIDE;

[jeremy, 2013/03/11 06:49:59]

// IPC::ChannelFactory::Delegate implementation. Also bellow.

[jeremya, 2013/03/11 08:42:26]

Done.

+  virtual void OnListenError() OVERRIDE {}
+
+  void InitOnFileThread();
+  void ListenOnIO();

[Mark Mentovai, 2013/03/11 12:40:37]

Can you add the word “thread” to this one too?

+
+  IPC::ChannelFactory* factory_;
+};
+
+#endif  // CHROME_BROWSER_WEB_APPLICATIONS_APP_SHIM_HOST_CONTROLLER_H_