[mac] App shims

apps/app_shim/app_shim_host_unittest.cc

Index: apps/app_shim/app_shim_host_unittest.cc
diff --git a/apps/app_shim/app_shim_host_unittest.cc b/apps/app_shim/app_shim_host_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..4734d96a2c040bfad63690495ae9fd121fd2f248
--- /dev/null
+++ b/apps/app_shim/app_shim_host_unittest.cc
@@ -0,0 +1,128 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "apps/app_shim/app_shim_host.h"
+
+#include "apps/app_shim/app_shim_messages.h"
+#include "base/memory/scoped_vector.h"
+#include "chrome/test/base/testing_profile.h"
+#include "ipc/ipc_message.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class TestingAppShimHost : public AppShimHost {
+ public:
+  explicit TestingAppShimHost(Profile* profile);
+  virtual ~TestingAppShimHost() {}
+
+  bool SendFakeMessage(IPC::Message* message);
+
+  const std::vector<IPC::Message*>& sent_messages() {
+    return sent_messages_.get();
+  }
+
+  void set_fails_profile(bool fails_profile) {
+    fails_profile_ = fails_profile;
+  }
+
+  void set_fails_launch(bool fails_launch) {
+    fails_launch_ = fails_launch;
+  }
+
+ protected:
+  virtual Profile* FetchProfileForDirectory(const std::string& profile_dir)
+      OVERRIDE;
+  virtual bool LaunchApp(Profile* profile, const std::string& app_id) OVERRIDE;
+
+  virtual bool Send(IPC::Message* message) OVERRIDE;
+
+  Profile* test_profile_;
+  bool fails_profile_;
+  bool fails_launch_;
+
+  ScopedVector<IPC::Message> sent_messages_;
+
+  DISALLOW_COPY_AND_ASSIGN(TestingAppShimHost);
+};
+
+TestingAppShimHost::TestingAppShimHost(Profile* profile)
+    : test_profile_(profile),
+      fails_profile_(false),
+      fails_launch_(false) {
+}
+
+bool TestingAppShimHost::SendFakeMessage(IPC::Message* message) {

[koz (OOO until 15th September), 2013/03/14 23:51:05]

I think this would be better named as ReceiveFakeMessage(). Or even just
ReceiveMessage().

[jeremya, 2013/03/15 02:24:14]

Done.

+  bool handled = OnMessageReceived(*message);
+  delete message;
+  return handled;
+}
+
+bool TestingAppShimHost::Send(IPC::Message* message) {
+  sent_messages_.push_back(message);
+  return true;
+}
+
+Profile* TestingAppShimHost::FetchProfileForDirectory(
+    const std::string& profile_dir) {
+  return fails_profile_ ? NULL : test_profile_;
+}
+
+bool TestingAppShimHost::LaunchApp(
+    Profile* profile, const std::string& app_id) {
+  return !fails_launch_;
+}
+
+class AppShimHostTest : public testing::Test {
+ public:
+  TestingAppShimHost* host() { return host_; }
+  TestingProfile* profile() { return profile_; }
+
+  bool LaunchWasSuccessful() {
+    EXPECT_EQ(1u, host()->sent_messages().size());
+    IPC::Message* message = host()->sent_messages()[0];
+    EXPECT_EQ(AppShimMsg_LaunchApp_Done::ID, message->type());
+    AppShimMsg_LaunchApp_Done::Param param;
+    AppShimMsg_LaunchApp_Done::Read(message, &param);
+    return param.a;
+  }
+
+ private:
+  virtual void SetUp() OVERRIDE {
+    profile_ = new TestingProfile;
+    host_ = new TestingAppShimHost(profile_);
+  }
+  virtual void TearDown() OVERRIDE {
+    delete host_;
+    delete profile_;
+  }
+
+  TestingAppShimHost* host_;

[koz (OOO until 15th September), 2013/03/14 23:51:05]

scoped_ptrs means you don't need a TearDown().

[jeremya, 2013/03/15 02:24:14]

Like magic!

+  TestingProfile* profile_;
+};
+
+static const std::string kTestAppId = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
+static const std::string kTestProfileDir = "Default";
+
+TEST_F(AppShimHostTest, TestLaunchApp) {
+  host()->SendFakeMessage(
+      new AppShimHostMsg_LaunchApp(kTestProfileDir, kTestAppId));
+  ASSERT_EQ(kTestAppId, host()->app_id());
+  ASSERT_EQ(profile(), host()->profile());
+  ASSERT_EQ(true, LaunchWasSuccessful());

[koz (OOO until 15th September), 2013/03/14 23:51:05]

nit: ASSERT_TRUE

[jeremya, 2013/03/15 02:24:14]

Done.

+}
+
+TEST_F(AppShimHostTest, TestFailProfile) {
+  host()->set_fails_profile(true);
+  host()->SendFakeMessage(
+      new AppShimHostMsg_LaunchApp(kTestProfileDir, kTestAppId));
+  ASSERT_EQ(0u, host()->app_id().length());

[koz (OOO until 15th September), 2013/03/14 23:51:05]

nit: host()->app_id().empty()

[jeremya, 2013/03/15 02:24:14]

Done.

+  ASSERT_EQ(false, LaunchWasSuccessful());

[koz (OOO until 15th September), 2013/03/14 23:51:05]

nit: ASSERT_FALSE

[jeremya, 2013/03/15 02:24:14]

Done.

+}
+
+TEST_F(AppShimHostTest, TestFailLaunch) {
+  host()->set_fails_launch(true);
+  host()->SendFakeMessage(
+      new AppShimHostMsg_LaunchApp(kTestProfileDir, kTestAppId));
+  ASSERT_EQ(0u, host()->app_id().length());

[koz (OOO until 15th September), 2013/03/14 23:51:05]

s/length/empty()

[jeremya, 2013/03/15 02:24:14]

Done.

+  ASSERT_EQ(false, LaunchWasSuccessful());

[koz (OOO until 15th September), 2013/03/14 23:51:05]

nit: ASSERT_FALSE

[jeremya, 2013/03/15 02:24:14]

Done.

+}