chrome/common/app_shim_messages.h - Issue 12623005: [mac] App shims

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/app_shim_messages.h

Issue 12623005: [mac] App shims (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Multiply-included message file, hence no include guard.

	6

	7 #include <string>

	8

	9 #include "ipc/ipc_message_macros.h"

	10

	11 #define IPC_MESSAGE_START AppShimMsgStart
	jeremy 2013/03/11 06:49:59 Since we're dealing with new IPC messages can you Since we're dealing with new IPC messages can you double check that you're validating all parameters defensively when receiving these messages? Also, might want to get someone from the security team to double-check this part of the code review. jeremya 2013/03/11 08:42:26 Good idea. I think palmer@ is a security fellow? Show quoted text On 2013/03/11 06:49:59, jeremy wrote: > Since we're dealing with new IPC messages can you double check that you're > validating all parameters defensively when receiving these messages? Also, > might want to get someone from the security team to double-check this part of > the code review. Good idea. I think palmer@ is a security fellow? I'm not entirely sure how to validate the profile name...
	12

	13 IPC_MESSAGE_CONTROL1(AppShimMsg_LaunchApp_Done,
	jeremy 2013/03/11 06:49:59 Comments on what each message does. Comments on what each message does. jeremya 2013/03/11 08:42:26 Done. Show quoted text On 2013/03/11 06:49:59, jeremy wrote: > Comments on what each message does. Done.
	14 bool /* succeeded */)

	15

	16 IPC_MESSAGE_CONTROL2(AppShimHostMsg_LaunchApp,

	17 std::string /* profile name */,

	18 std::string /* app id */)

OLD	NEW

« chrome/browser/web_applications/app_shim_host_controller.mm ('K') | « chrome/chrome_common.gypi ('k') | chrome/common/common_message_generator.h » ('j') | no next file with comments »