[mac] App shims

chrome/browser/web_applications/app_shim_host_controller.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_WEB_APPLICATIONS_APP_SHIM_HOST_CONTROLLER_H_
+#define CHROME_BROWSER_WEB_APPLICATIONS_APP_SHIM_HOST_CONTROLLER_H_
+
+#include "base/mac/scoped_cftyperef.h"
+#include "base/memory/weak_ptr.h"
+#include "base/threading/thread.h"
+#include "ipc/ipc_channel_factory.h"
+
+// singleton

[Mark Mentovai, 2013/03/08 16:50:17]

You’re gonna need more docs than this.

[jeremya, 2013/03/11 02:47:33]

I've always liked concise documentation ;)

+class AppShimHostController
+    : public IPC::ChannelFactory::Delegate,
+      public base::SupportsWeakPtr<AppShimHostController> {
+ public:
+  AppShimHostController();
+  virtual ~AppShimHostController();
+
+ private:
+  virtual void OnClientConnected(const IPC::ChannelHandle& handle) OVERRIDE;
+  virtual void OnListenError() OVERRIDE {}
+
+  void InitOnFile();

[Mark Mentovai, 2013/03/08 16:50:17]

InitOnFile’s a funny name because (1) there is no file argument, the
implementation figures it out itself, and there’s no other way to initialize it,
and (2) it’s not really a file, it’s a UNIX-domain socket.

[jeremya, 2013/03/11 02:47:33]

InitOnFileThread make more sense? :)

[Mark Mentovai, 2013/03/11 12:40:37]

jeremya wrote:
Yeah, it does! See, I had no idea that “file” meant “file thread” instead of
“filesystem node.”

+  void ListenOnIO();
+
+  IPC::ChannelFactory* factory_;
+};
+
+#endif  // CHROME_BROWSER_WEB_APPLICATIONS_APP_SHIM_HOST_CONTROLLER_H_