Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: chrome/test/nacl/nacl_browsertest_util.h

Issue 12623004: Allow PNaCl NMF to set translator optimization options for experimentation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Default to -O0 instead of the default for now Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_ 5 #ifndef CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_
6 #define CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_ 6 #define CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_
7 7
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "chrome/test/base/in_process_browser_test.h" 10 #include "chrome/test/base/in_process_browser_test.h"
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 virtual bool IsPnacl() OVERRIDE; 123 virtual bool IsPnacl() OVERRIDE;
124 }; 124 };
125 125
126 // A NaCl browser test only using static files. 126 // A NaCl browser test only using static files.
127 class NaClBrowserTestStatic : public NaClBrowserTestBase { 127 class NaClBrowserTestStatic : public NaClBrowserTestBase {
128 public: 128 public:
129 virtual base::FilePath::StringType Variant() OVERRIDE; 129 virtual base::FilePath::StringType Variant() OVERRIDE;
130 virtual bool GetDocumentRoot(base::FilePath* document_root) OVERRIDE; 130 virtual bool GetDocumentRoot(base::FilePath* document_root) OVERRIDE;
131 }; 131 };
132 132
133 // PNaCl's cache and PPB_FileIO currently trip up under ASAN:
134 // https://code.google.com/p/chromium/issues/detail?id=171810
135 // PNaCl tests take a long time on windows debug builds
136 // and sometimes time out. Disable until it is made faster:
137 // https://code.google.com/p/chromium/issues/detail?id=177555
138 #if defined(ADDRESS_SANITIZER) || (defined(OS_WIN) && !defined(NDEBUG))
139 #define MAYBE_PNACL(test_name) DISABLED_##test_name
140 #else
141 #define MAYBE_PNACL(test_name) test_name
142 #endif
143
133 #if defined(ARCH_CPU_ARM_FAMILY) 144 #if defined(ARCH_CPU_ARM_FAMILY)
134 145
135 // There is no support for Glibc on ARM NaCl. 146 // There is no support for Glibc on ARM NaCl.
136 #define NACL_BROWSER_TEST_F(suite, name, body) \ 147 #define NACL_BROWSER_TEST_F(suite, name, body) \
137 IN_PROC_BROWSER_TEST_F(suite##Newlib, name) \ 148 IN_PROC_BROWSER_TEST_F(suite##Newlib, name) \
138 body 149 body
139 150
140 #elif defined(ADDRESS_SANITIZER) || (defined(OS_WIN) && !defined(NDEBUG))
141 // PNaCl's cache and PPB_FileIO currently trip up under ASAN:
142 // https://code.google.com/p/chromium/issues/detail?id=171810
143 // PNaCl tests take a long time on windows debug builds
144 // and sometimes time out. Disable until it is made faster:
145 // https://code.google.com/p/chromium/issues/detail?id=177555
146 #define NACL_BROWSER_TEST_F(suite, name, body) \
147 IN_PROC_BROWSER_TEST_F(suite##Newlib, name) \
148 body \
149 IN_PROC_BROWSER_TEST_F(suite##GLibc, name) \
150 body
151
152 #else 151 #else
153 152
154 // Otherwise, we have Glibc, Newlib and PNaCl tests 153 // Otherwise, we have Glibc, Newlib and PNaCl tests
155 #define NACL_BROWSER_TEST_F(suite, name, body) \ 154 #define NACL_BROWSER_TEST_F(suite, name, body) \
156 IN_PROC_BROWSER_TEST_F(suite##Newlib, name) \ 155 IN_PROC_BROWSER_TEST_F(suite##Newlib, name) \
157 body \ 156 body \
158 IN_PROC_BROWSER_TEST_F(suite##GLibc, name) \ 157 IN_PROC_BROWSER_TEST_F(suite##GLibc, name) \
159 body \ 158 body \
160 IN_PROC_BROWSER_TEST_F(suite##Pnacl, name) \ 159 IN_PROC_BROWSER_TEST_F(suite##Pnacl, MAYBE_PNACL(name)) \
161 body 160 body
162 161
163 #endif 162 #endif
164 163
165 #endif // CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_ 164 #endif // CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_
OLDNEW
« no previous file with comments | « chrome/test/nacl/nacl_browsertest.cc ('k') | ppapi/native_client/src/trusted/plugin/json_manifest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698