Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 1262283002: Fix 50% flip handling of CSS Animations using CSS wide keywords (Closed)

Created:
5 years, 4 months ago by alancutter (OOO until 2018)
Modified:
5 years, 4 months ago
Reviewers:
dstockwell, shans
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, rjwright
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix 50% flip handling of CSS Animations using CSS wide keywords CSS Animations of certain properties [1] were handling CSS wide keywords like inherit as 50% flip cases instead of smoothly interpolating when appropriate. This patch makes all CSS wide keywords fall back to either LegacyStyleInterpolation or DeferredLegacyStyleInterpolation before attempting *StyleInterpolation conversion which fixes smooth interpolation of these keywords. [1] border-image-slice list-style-image -webkit-mask-box-image -webkit-mask-box-image-source BUG=437696 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199936

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+590 lines, -205 lines) Patch
M LayoutTests/animations/interpolation/border-image-slice-interpolation.html View 3 chunks +60 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/border-image-source-interpolation.html View 2 chunks +63 lines, -44 lines 0 comments Download
M LayoutTests/animations/interpolation/border-image-source-interpolation-expected.txt View 4 chunks +86 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/list-style-image-interpolation.html View 2 chunks +63 lines, -57 lines 0 comments Download
M LayoutTests/animations/interpolation/list-style-image-interpolation-expected.txt View 4 chunks +89 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/resources/interpolation-test.js View 6 chunks +19 lines, -11 lines 0 comments Download
M LayoutTests/animations/interpolation/webkit-mask-box-image-slice-interpolation.html View 3 chunks +45 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/webkit-mask-box-image-source-interpolation.html View 1 chunk +70 lines, -57 lines 0 comments Download
M LayoutTests/animations/interpolation/webkit-mask-box-image-source-interpolation-expected.txt View 3 chunks +62 lines, -0 lines 0 comments Download
M Source/core/animation/StringKeyframe.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 1 10 chunks +32 lines, -36 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
alancutter (OOO until 2018)
5 years, 4 months ago (2015-07-30 05:44:38 UTC) #2
shans
On 2015/07/30 05:44:38, alancutter wrote: LGTM (I thought from the description that you were falling ...
5 years, 4 months ago (2015-08-03 10:44:21 UTC) #3
alancutter (OOO until 2018)
On 2015/08/03 at 10:44:21, shans wrote: > On 2015/07/30 05:44:38, alancutter wrote: > > LGTM ...
5 years, 4 months ago (2015-08-04 02:55:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262283002/20001
5 years, 4 months ago (2015-08-04 02:55:41 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 04:17:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199936

Powered by Google App Engine
This is Rietveld 408576698