Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1262253002:
Turn Client-Hints' DPR, Width and Viewport-Width on by default. (Closed)
|
Created:
5 years, 4 months ago by Yoav Weiss Modified:
5 years, 4 months ago Reviewers:
Mike West CC:
blink-reviews Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionTurn Client-Hints' DPR, Width and Viewport-Width on by default.
Intent to ship thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/vvX1vCQihDE/wg6JQg9utaMJ
BUG=458983
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200414
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 18 (7 generated)
yoav@yoav.ws changed reviewers: + mkwst@chromium.org
Hey Mike, Prepared this so it'd be easier to commit once the spec passes privacy review :)
LGTM.
On 2015/08/12 at 04:29:44, Mike West (slow) wrote: > LGTM. (Though I don't see any LGTMs on the intent to ship thread...)
On 2015/08/12 04:31:03, Mike West (slow) wrote: > On 2015/08/12 at 04:29:44, Mike West (slow) wrote: > > LGTM. > > (Though I don't see any LGTMs on the intent to ship thread...) LGTMs have somehow branched into https://groups.google.com/a/chromium.org/d/msg/blink-dev/ATbqmznya_k/kuj9erD9...
On 2015/08/12 04:36:44, Yoav Weiss (OOO until 15th) wrote: > On 2015/08/12 04:31:03, Mike West (slow) wrote: > > On 2015/08/12 at 04:29:44, Mike West (slow) wrote: > > > LGTM. > > > > (Though I don't see any LGTMs on the intent to ship thread...) > > LGTMs have somehow branched into > https://groups.google.com/a/chromium.org/d/msg/blink-dev/ATbqmznya_k/kuj9erD9... Followed up on the original thread with a link to the second part (woops!). I believe we're all good to go now! Yoav, will you do the honours and land this? :)
The CQ bit was checked by yoav@yoav.ws
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262253002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_blink_compile_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...) linux_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_compile_dbg/...) linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/7...) mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
On 2015/08/12 14:52:51, igrigorik wrote: > On 2015/08/12 04:36:44, Yoav Weiss (OOO until 15th) wrote: > > On 2015/08/12 04:31:03, Mike West (slow) wrote: > > > On 2015/08/12 at 04:29:44, Mike West (slow) wrote: > > > > LGTM. > > > > > > (Though I don't see any LGTMs on the intent to ship thread...) > > > > LGTMs have somehow branched into > > > https://groups.google.com/a/chromium.org/d/msg/blink-dev/ATbqmznya_k/kuj9erD9... > > Followed up on the original thread with a link to the second part (woops!). > > I believe we're all good to go now! Yoav, will you do the honours and land this? > :) Thanks Ilya :) Rebased and CQing (again...)
The CQ bit was checked by yoav@yoav.ws
The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org Link to the patchset: https://codereview.chromium.org/1262253002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262253002/20001
The CQ bit was unchecked by yoav@yoav.ws
The CQ bit was checked by yoav@yoav.ws
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262253002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=200414 |
