Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1262253002: Turn Client-Hints' DPR, Width and Viewport-Width on by default. (Closed)

Created:
5 years, 4 months ago by Yoav Weiss
Modified:
5 years, 4 months ago
Reviewers:
Mike West
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Turn Client-Hints' DPR, Width and Viewport-Width on by default. Intent to ship thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/vvX1vCQihDE/wg6JQg9utaMJ BUG=458983 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200414

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
Yoav Weiss
Hey Mike, Prepared this so it'd be easier to commit once the spec passes privacy ...
5 years, 4 months ago (2015-08-01 02:19:07 UTC) #2
Mike West
LGTM.
5 years, 4 months ago (2015-08-12 04:29:44 UTC) #3
Mike West
On 2015/08/12 at 04:29:44, Mike West (slow) wrote: > LGTM. (Though I don't see any ...
5 years, 4 months ago (2015-08-12 04:31:03 UTC) #4
Yoav Weiss
On 2015/08/12 04:31:03, Mike West (slow) wrote: > On 2015/08/12 at 04:29:44, Mike West (slow) ...
5 years, 4 months ago (2015-08-12 04:36:44 UTC) #5
igrigorik
On 2015/08/12 04:36:44, Yoav Weiss (OOO until 15th) wrote: > On 2015/08/12 04:31:03, Mike West ...
5 years, 4 months ago (2015-08-12 14:52:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262253002/1
5 years, 4 months ago (2015-08-12 15:14:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_rel/builds/45780) linux_blink_compile_dbg on tryserver.blink (JOB_FAILED, ...
5 years, 4 months ago (2015-08-12 15:17:04 UTC) #10
Yoav Weiss
On 2015/08/12 14:52:51, igrigorik wrote: > On 2015/08/12 04:36:44, Yoav Weiss (OOO until 15th) wrote: ...
5 years, 4 months ago (2015-08-12 16:32:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262253002/20001
5 years, 4 months ago (2015-08-12 16:32:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262253002/20001
5 years, 4 months ago (2015-08-12 18:21:49 UTC) #17
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 19:10:45 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200414

Powered by Google App Engine
This is Rietveld 408576698