Issue 126223002: [NaCl SDK] Add ARM sel_ldr to linux SDK

Issue 126223002: [NaCl SDK] Add ARM sel_ldr to linux SDK (Closed)

Created:
6 years, 11 months ago by Sam Clegg

Modified:
6 years, 9 months ago

Reviewers:
noelallen1, binji

CC:
chromium-reviews, binji

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Add ARM sel_ldr to linux SDK BUG=266959

Patch Set 2 : #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -11 lines)			Patch
	M	native_client_sdk/src/build_tools/build_sdk.py	View	1	3 chunks	+22 lines, -11 lines	1 comment	Download
	M	native_client_sdk/src/build_tools/sdk_files.list	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Sam Clegg

Can't land this until the next NaCl DEPS roll but I've tested locally.

6 years, 11 months ago (2014-01-08 22:43:52 UTC) #1

binji

lgtm, but as we've discussed this needs to wait for installing the arm toolchain in ...

6 years, 11 months ago (2014-01-08 23:01:15 UTC) #3

Sam Clegg

Just waiting on the bots installation now. https://codereview.chromium.org/126223002/diff/1/native_client_sdk/src/build_tools/sdk_files.list File native_client_sdk/src/build_tools/sdk_files.list (right): https://codereview.chromium.org/126223002/diff/1/native_client_sdk/src/build_tools/sdk_files.list#newcode422 native_client_sdk/src/build_tools/sdk_files.list:422: tools/irt_core_x86_64.nexe On ...

6 years, 11 months ago (2014-01-18 00:16:01 UTC) #4

noelallen1

https://codereview.chromium.org/126223002/diff/130001/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (right): https://codereview.chromium.org/126223002/diff/130001/native_client_sdk/src/build_tools/build_sdk.py#newcode416 native_client_sdk/src/build_tools/build_sdk.py:416: ['irt_core_newlib_x64.nexe', 'irt_core_x86_64.nexe'], x86_32?

6 years, 9 months ago (2014-03-08 01:02:52 UTC) #5

Sam Clegg

Noel, did you end up cloning this CL? Should I still try and submit it ...

6 years, 9 months ago (2014-03-24 23:42:48 UTC) #6

Sam Clegg

6 years, 9 months ago (2014-03-28 23:40:50 UTC) #8

On 2014/03/27 00:23:40, noelallen1 wrote:
> I've sent you a review.

Dropping this CL..

Expand Messages | Collapse Messages