Issue 12622003: Merge 144463

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12622003: Merge 144463 (Closed)

Created:
7 years, 9 months ago by vsevik

Modified:
7 years, 9 months ago

Reviewers:
vsevik

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/

Visibility:
Public.

More Reviews

Description

Merge 144463 > Web Inspector: [Regression] Snippets renaming is broken. > https://bugs.webkit.org/show_bug.cgi?id=111181 > > Reviewed by Alexander Pavlov. > > Source/WebCore: > > * inspector/front-end/NavigatorView.js: > * inspector/front-end/ScriptSnippetModel.js: > * inspector/front-end/ScriptsPanel.js: > (WebInspector.ScriptsPanel.prototype.set _fileRenamed): > * inspector/front-end/UISourceCode.js: > (WebInspector.UISourceCode.prototype.rename): > > LayoutTests: > > * inspector/debugger/script-snippet-model.html: > TBR=vsevik@chromium.org BUG=179368 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145089

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -6 lines)			Patch
M	LayoutTests/inspector/debugger/script-snippet-model.html	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	Source/WebCore/inspector/front-end/NavigatorView.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/inspector/front-end/ScriptSnippetModel.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/WebCore/inspector/front-end/ScriptsPanel.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/WebCore/inspector/front-end/UISourceCode.js	View	1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r145089.

Expand Messages | Collapse Messages