Use time.Time for internal memcache memory implementation

Use time.Time for internal memcache memory implementation

Followup to https://chromiumcodereview.appspot.com/1270063003/

R=dnj@chromium.org, estaab@chromium.org, tandrii@chromium.org, vadimsh@chromium.org
BUG=

Committed: https://github.com/luci/gae/commit/40b224e66512cc08f4100c800dcb4f5d4dcfcd2f

[dnj, 2015-08-04 17:55:43]

https://codereview.chromium.org/1262173003/diff/1/impl/memory/memcache.go
File impl/memory/memcache.go (right):

https://codereview.chromium.org/1262173003/diff/1/impl/memory/memcache.go#new...
impl/memory/memcache.go:66: return &mcItem{key, value, m.flags, 0, m.casID}
Shouldn't you use "m.expiration.UTC().UnixNano() / <whatever>" here instead of
"0"?

https://codereview.chromium.org/1262173003/diff/1/impl/memory/memcache.go#new...
impl/memory/memcache.go:80: var exp time.Time
maruel@ prefers: exp := time.Time{}

This seems to be the notation we've been using.

[iannucci, 2015-08-04 18:13:54]

ptal

https://codereview.chromium.org/1262173003/diff/1/impl/memory/memcache.go
File impl/memory/memcache.go (right):

https://codereview.chromium.org/1262173003/diff/1/impl/memory/memcache.go#new...
impl/memory/memcache.go:66: return &mcItem{key, value, m.flags, 0, m.casID}
On 2015/08/04 17:55:42, dnj wrote:
> Shouldn't you use "m.expiration.UTC().UnixNano() / <whatever>" here instead of
> "0"?

Nah, the memcache api defines Expiration has having 0 when getting items back
from the server. added comment.

https://codereview.chromium.org/1262173003/diff/1/impl/memory/memcache.go#new...
impl/memory/memcache.go:80: var exp time.Time
On 2015/08/04 17:55:43, dnj wrote:
> maruel@ prefers: exp := time.Time{}
> 
> This seems to be the notation we've been using.

Weird. I usually do that too.

[dnj, 2015-08-04 20:58:41]

lgtm

[iannucci, 2015-08-04 21:05:41]

Committed patchset #2 (id:20001) manually as
40b224e66512cc08f4100c800dcb4f5d4dcfcd2f (presubmit successful).