Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1262143002: rewrite path.getBounds test to work-around compiler bug (Closed)

Created:
5 years, 4 months ago by reed1
Modified:
5 years, 4 months ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

rewrite path.getBounds test to work-around compiler bug BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/3b2fb981ab8d011077eb6de7eec5fe1f590906b3

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M tests/PathTest.cpp View 2 chunks +23 lines, -1 line 1 comment Download

Messages

Total messages: 12 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262143002/1
5 years, 4 months ago (2015-07-29 15:29:30 UTC) #2
mtklein
https://codereview.chromium.org/1262143002/diff/1/tests/PathTest.cpp File tests/PathTest.cpp (right): https://codereview.chromium.org/1262143002/diff/1/tests/PathTest.cpp#newcode582 tests/PathTest.cpp:582: // As written these tests were failing on LLVM ...
5 years, 4 months ago (2015-07-29 15:34:14 UTC) #4
reed1
Eric typed > clang --version and got what I said (I think)...
5 years, 4 months ago (2015-07-29 15:35:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/3b2fb981ab8d011077eb6de7eec5fe1f590906b3
5 years, 4 months ago (2015-07-29 15:37:16 UTC) #7
mtklein
Ah, so weird. Apple always makes such strange lies about LLVM and Clang versions. I ...
5 years, 4 months ago (2015-07-29 15:46:53 UTC) #8
reed1
eric, can you paste the entitreity of your output?
5 years, 4 months ago (2015-07-29 15:47:54 UTC) #9
mtklein
On 2015/07/29 15:47:54, reed1 wrote: > eric, can you paste the entitreity of your output? ...
5 years, 4 months ago (2015-07-29 15:53:18 UTC) #10
borenet
On 2015/07/29 15:53:18, mtklein wrote: > On 2015/07/29 15:47:54, reed1 wrote: > > eric, can ...
5 years, 4 months ago (2015-07-29 16:25:17 UTC) #11
mtklein
5 years, 4 months ago (2015-07-29 16:25:50 UTC) #12
Message was sent while issue was closed.
On 2015/07/29 16:25:17, borenet wrote:
> On 2015/07/29 15:53:18, mtklein wrote:
> > On 2015/07/29 15:47:54, reed1 wrote:
> > > eric, can you paste the entitreity of your output?
> > 
> > https://en.wikipedia.org/wiki/Xcode#Toolchain_versions
> 
> skiabot-macmini-10_8-001:~ chrome-bot$ clang --version
> Apple LLVM version 4.2 (clang-425.0.24) (based on LLVM 3.2svn)
> Target: x86_64-apple-darwin12.5.0
> Thread model: posix

Thanks!  Wow, good thing we're upgrading these bots...

Powered by Google App Engine
This is Rietveld 408576698