Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 1262123003: Files.app: make files-toggle-ripple unclickable. (Closed)

Created:
5 years, 4 months ago by yawano
Modified:
5 years, 4 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: make files-toggle-ripple unclickable. files-toggle-ripple reserves double size of its container to perform its ripple animation. If it's clickable, it sometimes captures click event and it's confusing for users of this element. This CL makes the layer to perform ripple animation unclickable. BUG=515414 TEST=manually tested as described in the issue. Committed: https://crrev.com/c12d33d8e1496e6331bc5ee05e7d4fb01652545b Cr-Commit-Position: refs/heads/master@{#341102}

Patch Set 1 #

Patch Set 2 : Move pointer-events:none from host to ripple-container. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/file_manager/file_manager/foreground/elements/files_toggle_ripple.html View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
yawano
PTAL. Thank you!
5 years, 4 months ago (2015-07-30 11:07:29 UTC) #2
yawano
We didn't need to set pointer-events:none to the host. It's enough to set to the ...
5 years, 4 months ago (2015-07-30 11:11:43 UTC) #3
fukino
lgtm
5 years, 4 months ago (2015-07-30 11:47:50 UTC) #4
yawano
On 2015/07/30 11:47:50, fukino wrote: > lgtm Thank you!
5 years, 4 months ago (2015-07-30 11:56:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262123003/20001
5 years, 4 months ago (2015-07-30 11:56:20 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-30 12:31:51 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 12:32:53 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c12d33d8e1496e6331bc5ee05e7d4fb01652545b
Cr-Commit-Position: refs/heads/master@{#341102}

Powered by Google App Engine
This is Rietveld 408576698