Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1262103002: [Android] Catch device exceptions from individual test shards. (Closed)

Created:
5 years, 4 months ago by jbudorick
Modified:
5 years, 4 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Catch device exceptions from individual test shards. Currently, if any one device fails but all tests pass on other devices, the test run fails _even though_ all tests have succeeded. This patch changes that -- if all tests pass, the test run will pass even if a device fails. (If a test fails, or if all devices fail and not all tests run, the test run will still fail.) BUG= Committed: https://crrev.com/1ca6eaede71ea9ac9f00a0c3bb55119c8ddf676e Cr-Commit-Position: refs/heads/master@{#340876}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M build/android/pylib/base/test_dispatcher.py View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbudorick
5 years, 4 months ago (2015-07-29 05:43:40 UTC) #2
perezju
lgtm
5 years, 4 months ago (2015-07-29 08:50:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262103002/1
5 years, 4 months ago (2015-07-29 13:01:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-29 13:15:46 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 13:16:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ca6eaede71ea9ac9f00a0c3bb55119c8ddf676e
Cr-Commit-Position: refs/heads/master@{#340876}

Powered by Google App Engine
This is Rietveld 408576698