Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1688)

Unified Diff: chrome/common/url_constants.h

Issue 12621008: chrome-search: should not be display-isolated (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased to HEAD Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/render_messages.h ('k') | chrome/renderer/chrome_content_renderer_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/url_constants.h
diff --git a/chrome/common/url_constants.h b/chrome/common/url_constants.h
index ec06655c31828c383841c9e5e40fbbad9a1dcf04..34da032a3ebfef1c106a91d46306f7515b47d0d6 100644
--- a/chrome/common/url_constants.h
+++ b/chrome/common/url_constants.h
@@ -411,7 +411,18 @@ extern const char kExtensionResourceScheme[];
// only specific URLDataSources are enabled to serve requests via the
// chrome-search: scheme. See |InstantIOContext::ShouldServiceRequest| and its
// callers for details. Note that WebUIBindings should never be granted to
-// chrome-search: pages.
+// chrome-search: pages. chrome-search: pages are displayable but not readable
+// by external search providers (that are rendered by Instant renderer
+// processes), and neither displayable nor readable by normal (non-Instant) web
+// pages. To summarize, a non-Instant process, when trying to access
+// 'chrome-search://something', will bump up against the following:
+//
+// 1. Renderer: The display-isolated check in WebKit will deny the request,
+// 2. Browser: Assuming they got by #1, the scheme checks in
+// URLDataSource::ShouldServiceRequest will deny the request,
+// 3. Browser: for specific sub-classes of URLDataSource, like ThemeSource
+// there are additional Instant-PID checks that make sure the request is
+// coming from a blessed Instant process, and deny the request.
extern const char kChromeSearchScheme[];
// The local omnibox host and pages under chrome-search.
« no previous file with comments | « chrome/common/render_messages.h ('k') | chrome/renderer/chrome_content_renderer_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698