Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 12621004: Add an option to package test data to export_tarball script. (Closed)

Created:
7 years, 9 months ago by Paweł Hajdan Jr.
Modified:
7 years, 9 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Add an option to package test data to export_tarball script. It is helpful to have test data in a separate tarball, because then the main tarball (with everything needed to compile the browser) can be kept small while still allowing people to run tests as an option. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186981

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M tools/export_tarball/export_tarball.py View 1 7 chunks +18 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
7 years, 9 months ago (2013-03-07 23:04:44 UTC) #1
M-A Ruel
lgtm https://codereview.chromium.org/12621004/diff/1/tools/export_tarball/export_tarball.py File tools/export_tarball/export_tarball.py (right): https://codereview.chromium.org/12621004/diff/1/tools/export_tarball/export_tarball.py#newcode143 tools/export_tarball/export_tarball.py:143: if options.basename: output_basename = options.basename or os.path.basename(args[0]) https://codereview.chromium.org/12621004/diff/1/tools/export_tarball/export_tarball.py#newcode154 ...
7 years, 9 months ago (2013-03-08 02:10:54 UTC) #2
Paweł Hajdan Jr.
https://codereview.chromium.org/12621004/diff/1/tools/export_tarball/export_tarball.py File tools/export_tarball/export_tarball.py (right): https://codereview.chromium.org/12621004/diff/1/tools/export_tarball/export_tarball.py#newcode143 tools/export_tarball/export_tarball.py:143: if options.basename: On 2013/03/08 02:10:54, Marc-Antoine Ruel wrote: > ...
7 years, 9 months ago (2013-03-08 18:00:38 UTC) #3
Paweł Hajdan Jr.
7 years, 9 months ago (2013-03-08 18:04:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r186981 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698