Source/devtools/front_end/bindings/ResourceUtils.js - Issue 1262063003: Devtools UI: Remove redundant tooltips

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/bindings/ResourceUtils.js

Issue 1262063003: Devtools UI: Remove redundant tooltips (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/bindings/ResourceUtils.js

diff --git a/Source/devtools/front_end/bindings/ResourceUtils.js b/Source/devtools/front_end/bindings/ResourceUtils.js

index 0c7375aeba08718f6130e59bd8b69c8ea75e9cdd..0cc3a46b3115b1222b1160932ed7df7bb52b338b 100644

--- a/Source/devtools/front_end/bindings/ResourceUtils.js

+++ b/Source/devtools/front_end/bindings/ResourceUtils.js

@@ -177,9 +177,9 @@ WebInspector.linkifyURLAsNode = function(url, linkText, classes, isExternal, too

if (href !== null)

a.href = href;

a.className = classes;

- if (typeof tooltipText === "undefined")

+ if (!tooltipText && linkText !== url)

a.title = url;

- else if (typeof tooltipText !== "string" || tooltipText.length)

+ else if (tooltipText && tooltipText.length)

dgozman 2015/08/12 17:19:34 Just |if (tooltipText)| since empty string evaluat

samli 2015/08/17 00:53:26 Done.

a.title = tooltipText;

a.textContent = linkText.trimMiddle(WebInspector.Linkifier.MaxLengthForDisplayedURLs);

if (isExternal)