Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Side by Side Diff: Source/devtools/front_end/bindings/Linkifier.js

Issue 1262063003: Devtools UI: Remove redundant tooltips (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 * @param {number=} fallbackLineNumber 83 * @param {number=} fallbackLineNumber
84 * @param {string=} title 84 * @param {string=} title
85 * @param {string=} classes 85 * @param {string=} classes
86 * @return {!Element} 86 * @return {!Element}
87 */ 87 */
88 WebInspector.Linkifier.linkifyUsingRevealer = function(revealable, text, fallbac kHref, fallbackLineNumber, title, classes) 88 WebInspector.Linkifier.linkifyUsingRevealer = function(revealable, text, fallbac kHref, fallbackLineNumber, title, classes)
89 { 89 {
90 var a = createElement("a"); 90 var a = createElement("a");
91 a.className = (classes || "") + " webkit-html-resource-link"; 91 a.className = (classes || "") + " webkit-html-resource-link";
92 a.textContent = text.trimMiddle(WebInspector.Linkifier.MaxLengthForDisplayed URLs); 92 a.textContent = text.trimMiddle(WebInspector.Linkifier.MaxLengthForDisplayed URLs);
93 a.title = title || text; 93 if (title)
dgozman 2015/07/30 10:31:20 This change needs explanation.
samli 2015/08/03 01:16:26 Can't find where I was hitting this, sorry. Revert
94 a.title = title;
94 if (fallbackHref) { 95 if (fallbackHref) {
95 a.href = fallbackHref; 96 a.href = fallbackHref;
96 a.lineNumber = fallbackLineNumber; 97 a.lineNumber = fallbackLineNumber;
97 } 98 }
98 /** 99 /**
99 * @param {!Event} event 100 * @param {!Event} event
100 * @this {Object} 101 * @this {Object}
101 */ 102 */
102 function clickHandler(event) 103 function clickHandler(event)
103 { 104 {
(...skipping 310 matching lines...) Expand 10 before | Expand all | Expand 10 after
414 var debuggerModel = WebInspector.DebuggerModel.fromTarget(target); 415 var debuggerModel = WebInspector.DebuggerModel.fromTarget(target);
415 if (!debuggerModel) 416 if (!debuggerModel)
416 return ""; 417 return "";
417 var script = debuggerModel.scriptForId(scriptId); 418 var script = debuggerModel.scriptForId(scriptId);
418 if (!script) 419 if (!script)
419 return ""; 420 return "";
420 var location = /** @type {!WebInspector.DebuggerModel.Location} */ (debugger Model.createRawLocation(script, lineNumber, columnNumber || 0)); 421 var location = /** @type {!WebInspector.DebuggerModel.Location} */ (debugger Model.createRawLocation(script, lineNumber, columnNumber || 0));
421 var uiLocation = /** @type {!WebInspector.UILocation} */ (WebInspector.debug gerWorkspaceBinding.rawLocationToUILocation(location)); 422 var uiLocation = /** @type {!WebInspector.UILocation} */ (WebInspector.debug gerWorkspaceBinding.rawLocationToUILocation(location));
422 return uiLocation.linkText(); 423 return uiLocation.linkText();
423 } 424 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698