chrome/browser/push_messaging/push_messaging_notification_manager.cc - Issue 1262023003: Serialize Notification.direction == "auto" in the database (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_notification_manager.cc

Issue 1262023003: Serialize Notification.direction == "auto" in the database (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/notifications/notification_database_data.proto » ('j') | content/browser/notifications/notification_database_data_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/push_messaging/push_messaging_notification_manager.cc

diff --git a/chrome/browser/push_messaging/push_messaging_notification_manager.cc b/chrome/browser/push_messaging/push_messaging_notification_manager.cc

index a385f1f43ad4f12973992b3acf13ecdc629664e9..7e7cc92fdf0b307867dd6bb5fa683631c7250a54 100644

--- a/chrome/browser/push_messaging/push_messaging_notification_manager.cc

+++ b/chrome/browser/push_messaging/push_messaging_notification_manager.cc

@@ -262,7 +262,7 @@ void PushMessagingNotificationManager::DidGetNotificationsShownAndNeeded(

requesting_origin.host(),

net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES));

notification_data.direction =

- content::PlatformNotificationData::NotificationDirectionLeftToRight;

+ content::PlatformNotificationData::DIRECTION_LEFT_TO_RIGHT;

notification_data.body =

l10n_util::GetStringUTF16(IDS_PUSH_MESSAGING_GENERIC_NOTIFICATION_BODY);

notification_data.tag = kPushMessagingForcedNotificationTag;