Serialize Notification.direction == "auto" in the database (2/3)

content/child/notifications/notification_data_conversions_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/notifications/notification_data_conversions.h"
 
 #include <stdint.h>
 
 #include "base/strings/utf_string_conversions.h"
 #include "content/public/common/platform_notification_data.h"
@@ skipping 27 matching lines @@
       blink::WebString::fromUTF8(kNotificationLang),
       blink::WebString::fromUTF8(kNotificationBody),
       blink::WebString::fromUTF8(kNotificationTag),
       blink::WebURL(GURL(kNotificationIconUrl)),
       blink::WebVector<int>(vibration_pattern),
       true /* silent */,
       blink::WebVector<char>(developer_data));
 
   PlatformNotificationData platform_data = ToPlatformNotificationData(web_data);
   EXPECT_EQ(base::ASCIIToUTF16(kNotificationTitle), platform_data.title);
-  EXPECT_EQ(PlatformNotificationData::NotificationDirectionLeftToRight,
+  EXPECT_EQ(PlatformNotificationData::DIRECTION_LEFT_TO_RIGHT,
             platform_data.direction);
   EXPECT_EQ(kNotificationLang, platform_data.lang);
   EXPECT_EQ(base::ASCIIToUTF16(kNotificationBody), platform_data.body);
   EXPECT_EQ(kNotificationTag, platform_data.tag);
   EXPECT_EQ(kNotificationIconUrl, platform_data.icon.spec());
   EXPECT_TRUE(platform_data.silent);
 
   EXPECT_THAT(platform_data.vibration_pattern,
       testing::ElementsAreArray(kNotificationVibrationPattern));
 
   ASSERT_EQ(developer_data.size(), platform_data.data.size());
   for (size_t i = 0; i < developer_data.size(); ++i)
     EXPECT_EQ(developer_data[i], platform_data.data[i]);
 }
 
-TEST(NotificationDataConversionsTest,
-     ToPlatformNotificationDataDirectionality) {
-  blink::WebNotificationData web_data;
-  web_data.direction = blink::WebNotificationData::DirectionLeftToRight;
-
-  PlatformNotificationData platform_data = ToPlatformNotificationData(web_data);
-  EXPECT_EQ(PlatformNotificationData::NotificationDirectionLeftToRight,
-            platform_data.direction);
-
-  web_data.direction = blink::WebNotificationData::DirectionRightToLeft;
-
-  platform_data = ToPlatformNotificationData(web_data);
-  EXPECT_EQ(PlatformNotificationData::NotificationDirectionRightToLeft,
-            platform_data.direction);
-}
-
 TEST(NotificationDataConversionsTest, ToWebNotificationData) {
   std::vector<int> vibration_pattern(
       kNotificationVibrationPattern,
       kNotificationVibrationPattern + arraysize(kNotificationVibrationPattern));
 
   std::vector<char> developer_data(
       kNotificationData, kNotificationData + arraysize(kNotificationData));
 
   PlatformNotificationData platform_data;
   platform_data.title = base::ASCIIToUTF16(kNotificationTitle);
   platform_data.direction =
-      PlatformNotificationData::NotificationDirectionLeftToRight;
+      PlatformNotificationData::DIRECTION_LEFT_TO_RIGHT;
   platform_data.lang = kNotificationLang;
   platform_data.body = base::ASCIIToUTF16(kNotificationBody);
   platform_data.tag = kNotificationTag;
   platform_data.icon = GURL(kNotificationIconUrl);
   platform_data.vibration_pattern = vibration_pattern;
   platform_data.silent = true;
   platform_data.data = developer_data;
 
   blink::WebNotificationData web_data = ToWebNotificationData(platform_data);
   EXPECT_EQ(kNotificationTitle, web_data.title);
   EXPECT_EQ(blink::WebNotificationData::DirectionLeftToRight,
             web_data.direction);
   EXPECT_EQ(kNotificationLang, web_data.lang);
   EXPECT_EQ(kNotificationBody, web_data.body);
   EXPECT_EQ(kNotificationTag, web_data.tag);
   EXPECT_EQ(kNotificationIconUrl, web_data.icon.string());
 
   ASSERT_EQ(vibration_pattern.size(), web_data.vibrate.size());
   for (size_t i = 0; i < vibration_pattern.size(); ++i)
     EXPECT_EQ(vibration_pattern[i], web_data.vibrate[i]);
 
   EXPECT_TRUE(web_data.silent);
 
   ASSERT_EQ(developer_data.size(), web_data.data.size());
   for (size_t i = 0; i < developer_data.size(); ++i)
     EXPECT_EQ(developer_data[i], web_data.data[i]);
 }
 
-TEST(NotificationDataConversionsTest, ToWebNotificationDataDirectionality) {
-  PlatformNotificationData platform_data;
-  platform_data.direction =
-      PlatformNotificationData::NotificationDirectionLeftToRight;
+TEST(NotificationDataConversionsTest, NotificationDataDirectionality) {
+  std::map<blink::WebNotificationData::Direction,
+           PlatformNotificationData::Direction> mappings;
 
-  blink::WebNotificationData web_data = ToWebNotificationData(platform_data);
-  EXPECT_EQ(blink::WebNotificationData::DirectionLeftToRight,
-            web_data.direction);
+  mappings[blink::WebNotificationData::DirectionLeftToRight] =
+      PlatformNotificationData::DIRECTION_LEFT_TO_RIGHT;
+  mappings[blink::WebNotificationData::DirectionRightToLeft] =
+      PlatformNotificationData::DIRECTION_RIGHT_TO_LEFT;
+  mappings[blink::WebNotificationData::DirectionAuto] =
+      PlatformNotificationData::DIRECTION_AUTO;

[palmer, 2015/08/03 20:42:46]

Maybe a negative test case.

 
-  platform_data.direction =
-      PlatformNotificationData::NotificationDirectionRightToLeft;
+  for (const auto& pair : mappings) {
+    {
+      blink::WebNotificationData web_data;
+      web_data.direction = pair.first;
 
-  web_data = ToWebNotificationData(platform_data);
-  EXPECT_EQ(blink::WebNotificationData::DirectionRightToLeft,
-            web_data.direction);
+      PlatformNotificationData platform_data =
+          ToPlatformNotificationData(web_data);
+      EXPECT_EQ(pair.second, platform_data.direction);
+    }
+    {
+      PlatformNotificationData platform_data;
+      platform_data.direction = pair.second;
+
+      blink::WebNotificationData web_data =
+          ToWebNotificationData(platform_data);
+      EXPECT_EQ(pair.first, web_data.direction);
+    }
+  }
 }
 
 }  // namespace content