Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1261973002: Revert of Disable OriginReplicationAllowsAccessToStorage test. (Closed)

Created:
5 years, 4 months ago by dcheng
Modified:
5 years, 4 months ago
Reviewers:
Nico, alexmos
CC:
chromium-reviews, site-isolation-reviews_chromium.org, kenrb, lfg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable OriginReplicationAllowsAccessToStorage test. (patchset #1 id:1 of https://codereview.chromium.org/1030883003/) Reason for revert: RenderWidgets should be cleaned up properly now. Original issue's description: > Disable ChromeSitePerProcessTest.OriginReplicationAllowsAccessToStorage test. > > The test sometimes triggers a shutdown race condition that results in > a UAF in blink::FocusController::focusedOrMainFrame() in the renderer, > due to WebFrameWidgetImpl outliving Page. Disabling the test until > this is fixed. > > BUG=470055, 468319 > > Committed: https://crrev.com/66e181bccca3e36cd96252bfe00741cfb916ffef > Cr-Commit-Position: refs/heads/master@{#322053} TBR=thakis@chromium.org,alexmos@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=470055, 468319 Committed: https://crrev.com/b3d2e5780d728a0d18d2b05d78cac7b36666d29c Cr-Commit-Position: refs/heads/master@{#340765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/browser/chrome_site_per_process_browsertest.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
Created Revert of Disable OriginReplicationAllowsAccessToStorage test.
5 years, 4 months ago (2015-07-28 21:05:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261973002/1
5 years, 4 months ago (2015-07-28 21:05:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-28 21:06:28 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 21:07:06 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3d2e5780d728a0d18d2b05d78cac7b36666d29c
Cr-Commit-Position: refs/heads/master@{#340765}

Powered by Google App Engine
This is Rietveld 408576698