src/compiler/osr.cc - Issue 1261923007: [turbofan] Unify referencing of stack slots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/osr.cc

Issue 1261923007: [turbofan] Unify referencing of stack slots (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Review feedback Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/osr.cc

diff --git a/src/compiler/osr.cc b/src/compiler/osr.cc

index 6c4c49de7981657e86ef4c253668ea4cc16a6b7c..663cf57808715cd5dad5fe99dfa9bc9071a34982 100644

--- a/src/compiler/osr.cc

+++ b/src/compiler/osr.cc

@@ -328,8 +328,6 @@ void OsrHelper::SetupFrame(Frame* frame) {

// The optimized frame will subsume the unoptimized frame. Do so by reserving

// the first spill slots.

frame->ReserveSpillSlots(UnoptimizedFrameSlots());

- // The frame needs to be adjusted by the number of unoptimized frame slots.

- frame->SetOsrStackSlotCount(static_cast<int>(UnoptimizedFrameSlots()));

}

} // namespace compiler

« no previous file with comments | « src/compiler/mips64/code-generator-mips64.cc ('k') | src/compiler/pipeline.h » ('j') | no next file with comments »