src/compiler/register-allocator.cc - Issue 1261923007: [turbofan] Unify referencing of stack slots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/register-allocator.cc

Issue 1261923007: [turbofan] Unify referencing of stack slots (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Final tweaks Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/register-allocator.cc

diff --git a/src/compiler/register-allocator.cc b/src/compiler/register-allocator.cc

index 4a222a43bef66c2c22008e2a5ddbb8d2113f6a11..1d4f454479ec197b66ff01fab5d54252c6bb4e20 100644

--- a/src/compiler/register-allocator.cc

+++ b/src/compiler/register-allocator.cc

@@ -1364,7 +1364,7 @@ void ConstraintBuilder::MeetConstraintsAfter(int instr_index) {

// This value is produced on the stack, we never need to spill it.

if (first_output->IsStackSlot()) {

DCHECK(StackSlotOperand::cast(first_output)->index() <

- data()->frame()->GetSpillSlotCount());

+ data()->frame()->GetTotalFrameSlotCount());

range->SetSpillOperand(StackSlotOperand::cast(first_output));

range->SetSpillStartIndex(instr_index + 1);

assigned = true;