Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 1261923007: [turbofan] Unify referencing of stack slots (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Review feedback Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/frames.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 655 matching lines...) Expand 10 before | Expand all | Expand 10 after
666 value, 666 value,
667 environment->HasTaggedValueAt(env_offset + i), 667 environment->HasTaggedValueAt(env_offset + i),
668 environment->HasUint32ValueAt(env_offset + i), 668 environment->HasUint32ValueAt(env_offset + i),
669 object_index_pointer, 669 object_index_pointer,
670 dematerialized_index_pointer); 670 dematerialized_index_pointer);
671 } 671 }
672 return; 672 return;
673 } 673 }
674 674
675 if (op->IsStackSlot()) { 675 if (op->IsStackSlot()) {
676 int index = op->index();
677 if (index >= 0) {
678 index += StandardFrameConstants::kFixedFrameSize / kPointerSize;
679 }
676 if (is_tagged) { 680 if (is_tagged) {
677 translation->StoreStackSlot(op->index()); 681 translation->StoreStackSlot(index);
678 } else if (is_uint32) { 682 } else if (is_uint32) {
679 translation->StoreUint32StackSlot(op->index()); 683 translation->StoreUint32StackSlot(index);
680 } else { 684 } else {
681 translation->StoreInt32StackSlot(op->index()); 685 translation->StoreInt32StackSlot(index);
682 } 686 }
683 } else if (op->IsDoubleStackSlot()) { 687 } else if (op->IsDoubleStackSlot()) {
684 translation->StoreDoubleStackSlot(op->index()); 688 int index = op->index();
689 if (index >= 0) {
690 index += StandardFrameConstants::kFixedFrameSize / kPointerSize;
691 }
692 translation->StoreDoubleStackSlot(index);
685 } else if (op->IsRegister()) { 693 } else if (op->IsRegister()) {
686 Register reg = ToRegister(op); 694 Register reg = ToRegister(op);
687 if (is_tagged) { 695 if (is_tagged) {
688 translation->StoreRegister(reg); 696 translation->StoreRegister(reg);
689 } else if (is_uint32) { 697 } else if (is_uint32) {
690 translation->StoreUint32Register(reg); 698 translation->StoreUint32Register(reg);
691 } else { 699 } else {
692 translation->StoreInt32Register(reg); 700 translation->StoreInt32Register(reg);
693 } 701 }
694 } else if (op->IsDoubleRegister()) { 702 } else if (op->IsDoubleRegister()) {
(...skipping 5149 matching lines...) Expand 10 before | Expand all | Expand 10 after
5844 RecordSafepoint(Safepoint::kNoLazyDeopt); 5852 RecordSafepoint(Safepoint::kNoLazyDeopt);
5845 } 5853 }
5846 5854
5847 5855
5848 #undef __ 5856 #undef __
5849 5857
5850 } // namespace internal 5858 } // namespace internal
5851 } // namespace v8 5859 } // namespace v8
5852 5860
5853 #endif // V8_TARGET_ARCH_IA32 5861 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/frames.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698